about summary refs log tree commit homepage
path: root/lib/PublicInbox/Smsg.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-01-24 04:46:55 -0700
committerEric Wong <e@80x24.org>2021-01-24 15:46:10 -0400
commit72d4cd2a056040c4a90b4f75a77317af26a20779 (patch)
treea9ae6318a6be74f9ccd117adcf532fb44e2e532e /lib/PublicInbox/Smsg.pm
parent7355803ccf17bd609c9d667d3b9cadb2adfc31bd (diff)
downloadpublic-inbox-72d4cd2a056040c4a90b4f75a77317af26a20779.tar.gz
With Perl 5.10+, we can rely on the defined-or-assignment (//=)
operator to avoid repeatedly rewriting an SV.

This may not provide a measurable difference here, but
it's more consistent with current style where things like
commit a05445fb400108e60ede7d377cf3b26a0392eb24
("config: config_fh_parse: micro-optimize") provide a measurable
improvement.
Diffstat (limited to 'lib/PublicInbox/Smsg.pm')
-rw-r--r--lib/PublicInbox/Smsg.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/Smsg.pm b/lib/PublicInbox/Smsg.pm
index 2b72e8b5..b4cc2ecb 100644
--- a/lib/PublicInbox/Smsg.pm
+++ b/lib/PublicInbox/Smsg.pm
@@ -83,7 +83,7 @@ sub parse_references ($$$) {
                         warn "References: <$ref> too long, ignoring\n";
                         next;
                 }
-                push(@keep, $ref) unless $seen{$ref}++;
+                $seen{$ref} //= push(@keep, $ref);
         }
         $smsg->{references} = '<'.join('> <', @keep).'>' if @keep;
         \@keep;