diff options
author | Eric Wong <e@yhbt.net> | 2020-06-27 10:03:38 +0000 |
---|---|---|
committer | Eric Wong <e@yhbt.net> | 2020-06-28 22:27:15 +0000 |
commit | 94096cab6cd5e00c8a36a4a2667bdb9acf43d01f (patch) | |
tree | 791b61b5e115e6ca0835a4f55445795b0d766dc1 /lib/PublicInbox/NNTPdeflate.pm | |
parent | 58c0333adbdd9f5f82309cb6eef3c379f0ff064e (diff) | |
download | public-inbox-94096cab6cd5e00c8a36a4a2667bdb9acf43d01f.tar.gz |
Since the removal of pseudo-hash support in Perl 5.10, the "fields" module no longer provides the space or speed benefits it did in 5.8. It also does not allow for compile-time checks, only run-time checks. To me, the extra developer overhead in maintaining "use fields" args has become a hassle. None of our non-DS-related code uses fields.pm, nor do any of our current dependencies. In fact, Danga::Socket (which DS was originally forked from) and its subclasses are the only fields.pm users I've ever encountered in the wild. Removing fields may make our code more approachable to other Perl hackers. So stop using fields.pm and locked hashes, but continue to document what fields do for non-trivial classes.
Diffstat (limited to 'lib/PublicInbox/NNTPdeflate.pm')
-rw-r--r-- | lib/PublicInbox/NNTPdeflate.pm | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/lib/PublicInbox/NNTPdeflate.pm b/lib/PublicInbox/NNTPdeflate.pm index dec88aba..02af935f 100644 --- a/lib/PublicInbox/NNTPdeflate.pm +++ b/lib/PublicInbox/NNTPdeflate.pm @@ -16,11 +16,9 @@ # efficient in terms of server memory usage. package PublicInbox::NNTPdeflate; use strict; -use warnings; use 5.010_001; -use base qw(PublicInbox::NNTP); +use parent qw(PublicInbox::NNTP); use Compress::Raw::Zlib; -use Hash::Util qw(unlock_hash); # dependency of fields for perl 5.10+, anyways my %IN_OPT = ( -Bufsize => PublicInbox::NNTP::LINE_MAX, @@ -53,7 +51,6 @@ sub enable { $self->res('403 Unable to activate compression'); return; } - unlock_hash(%$self); $self->res('206 Compression active'); bless $self, $class; $self->{zin} = $in; |