about summary refs log tree commit homepage
path: root/lib/PublicInbox/NNTPD.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2020-11-28 05:09:16 +0000
committerEric Wong <e@80x24.org>2020-11-29 02:25:51 +0000
commitbdef958bdccc4b1d11cd8408a5c29167b5385dc0 (patch)
treec8bf5c2770964f148e783c6a82f89e72de5d255d /lib/PublicInbox/NNTPD.pm
parent2d3fc25afe7435992236ac143039b24248c5e74d (diff)
downloadpublic-inbox-bdef958bdccc4b1d11cd8408a5c29167b5385dc0.tar.gz
It's not worth confusing hackers reading the source to have
two ways to access the same (large) hash table.  So just
go through PublicInbox::Config objects for now since the
extra hash lookup isn't going to be noticeable.

I've also started favoring "for" instead of "foreach"
since they're the equivalent perlop and less wear on
my fingers + keyboard.
Diffstat (limited to 'lib/PublicInbox/NNTPD.pm')
-rw-r--r--lib/PublicInbox/NNTPD.pm3
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/PublicInbox/NNTPD.pm b/lib/PublicInbox/NNTPD.pm
index 33bc5fda..5e287857 100644
--- a/lib/PublicInbox/NNTPD.pm
+++ b/lib/PublicInbox/NNTPD.pm
@@ -60,9 +60,8 @@ sub refresh_groups {
                 }
         });
         $self->{groupnames} = [ sort(keys %$groups) ];
-        $self->{pi_config} = $pi_config;
         # this will destroy old groups that got deleted
-        $self->{groups} = $groups;
+        $self->{pi_config} = $pi_config;
 }
 
 sub idler_start {