smsg: remove remaining accessor methods

We'll continue to favor simpler data models that can be
used directly rather than wasting time and memory with
accessor APIs.

The ->from, ->to, -cc, ->mid, ->subject, >references methods can
all be trivially replaced by hash lookups since all their values
are stored in doc_data.  Most remaining callers of those methods
were test cases, anyways.

->from_name is only used in the PSGI code, so we can just
use ->psgi_cull to take care of populating the {from_name}
field.

1 files changed, 1 insertions, 1 deletions

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index a37910d1..ac13c7df 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -296,7 +296,7 @@ sub newnews_i {
         my $msgs = $over->query_ts($ts, $$prev);
         if (scalar @$msgs) {
                 more($self, '<' .
-                        join(">\r\n<", map { $_->mid } @$msgs ).
+                        join(">\r\n<", map { $_->{mid} } @$msgs ).
                         '>');
                 $$prev = $msgs->[-1]->{num};
         } else {