diff options
| author | Eric Wong <e@80x24.org> | 2019-12-21 08:00:00 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2019-12-22 03:55:38 +0000 |
| commit | 145190edbb9b031127d64671d5d8548086ce9fea (patch) | |
| tree | afcb0abf399e69a6e6a83e8e28f278cbbcbc0f77 /lib/PublicInbox/NNTP.pm | |
| parent | a1ad66cc2ae871c28d64325894d63ed08d3b6c1b (diff) | |
| download | public-inbox-145190edbb9b031127d64671d5d8548086ce9fea.tar.gz | |
...Instead of just returning a plain scalar inside an arrayref. This is because we usually pass the result of NNTP::get_range to Msgmap::msg_range. Upcoming changes will move us away from anonymous subroutines, so this change will make followup commits easier-to-digest as modifications to the underlying scalar can be more easily propagated between non-anonymous-subs.
Diffstat (limited to 'lib/PublicInbox/NNTP.pm')
| -rw-r--r-- | lib/PublicInbox/NNTP.pm | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm index e41e3f64..58724938 100644 --- a/lib/PublicInbox/NNTP.pm +++ b/lib/PublicInbox/NNTP.pm @@ -194,7 +194,7 @@ sub cmd_listgroup ($;$$) { return $r unless ref $r; my ($beg, $end) = @$r; long_response($self, sub { - $r = $mm->msg_range(\$beg, $end, 'num'); + $r = $mm->msg_range($beg, $end, 'num'); scalar(@$r) or return; more($self, join("\r\n", map { $_->[0] } @$r)); 1; @@ -583,7 +583,7 @@ sub get_range ($$) { $beg = $min if ($beg < $min); $end = $max if ($end > $max); return '420 No article(s) selected' if ($beg > $end); - [ $beg, $end ]; + [ \$beg, $end ]; } sub long_response ($$) { @@ -651,7 +651,7 @@ sub hdr_message_id ($$$) { # optimize XHDR Message-ID [range] for slrnpull. my ($beg, $end) = @$r; more($self, $xhdr ? r221 : r225); long_response($self, sub { - my $r = $mm->msg_range(\$beg, $end); + my $r = $mm->msg_range($beg, $end); @$r or return; more($self, join("\r\n", map { "$_->[0] <$_->[1]>" @@ -694,7 +694,7 @@ sub hdr_xref ($$$) { # optimize XHDR Xref [range] for rtin my ($beg, $end) = @$r; more($self, $xhdr ? r221 : r225); long_response($self, sub { - my $r = $mm->msg_range(\$beg, $end); + my $r = $mm->msg_range($beg, $end); @$r or return; more($self, join("\r\n", map { my $num = $_->[0]; @@ -727,7 +727,7 @@ sub hdr_searchmsg ($$$$) { return $r unless ref $r; my ($beg, $end) = @$r; more($self, $xhdr ? r221 : r225); - my $cur = $beg; + my $cur = $$beg; long_response($self, sub { my $msgs = $over->query_xover($cur, $end); my $nr = scalar @$msgs or return; @@ -813,9 +813,9 @@ sub cmd_xrover ($;$) { more($self, '224 Overview information follows'); long_response($self, sub { - my $h = over_header_for($over, $beg, 'references'); - more($self, "$beg $h") if defined($h); - $beg++ < $end; + my $h = over_header_for($over, $$beg, 'references'); + more($self, "$$beg $h") if defined($h); + $$beg++ < $end; }); } @@ -860,9 +860,9 @@ sub cmd_xover ($;$) { my $r = get_range($self, $range); return $r unless ref $r; my ($beg, $end) = @$r; - more($self, "224 Overview information follows for $beg to $end"); + more($self, "224 Overview information follows for $$beg to $end"); my $over = $self->{ng}->over; - my $cur = $beg; + my $cur = $$beg; long_response($self, sub { my $msgs = $over->query_xover($cur, $end); my $nr = scalar @$msgs or return; |