about summary refs log tree commit homepage
path: root/lib/PublicInbox/LeiRediff.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-09-03 08:54:22 +0000
committerEric Wong <e@80x24.org>2021-09-03 08:55:05 +0000
commita73b85cc93e635e5f8a0520ab0f21177fb8de478 (patch)
tree9394d9858dd62941584cb7482f8586aebec375b9 /lib/PublicInbox/LeiRediff.pm
parent0ea8c77b4339398131889afd2405b5e10abd8f57 (diff)
downloadpublic-inbox-a73b85cc93e635e5f8a0520ab0f21177fb8de478.tar.gz
lei: ->child_error less error-prone
I was calling "child_error(1, ...)" in a few places where I meant
to be calling "child_error(1 << 8, ...)" and inadvertantly
triggering SIGHUP in script/lei.  Since giving a zero exit code
to child_error makes no sense, just allow falsy values to
default to 1 << 8.
Diffstat (limited to 'lib/PublicInbox/LeiRediff.pm')
-rw-r--r--lib/PublicInbox/LeiRediff.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/LeiRediff.pm b/lib/PublicInbox/LeiRediff.pm
index 0ba5897c..60286b06 100644
--- a/lib/PublicInbox/LeiRediff.pm
+++ b/lib/PublicInbox/LeiRediff.pm
@@ -23,7 +23,7 @@ sub rediff_user_cb { # called by solver when done
         my $lei = $self->{lei};
         my $log_buf = delete $lei->{log_buf};
         $$log_buf =~ s/^/# /sgm;
-        ref($res) eq 'ARRAY' or return $lei->child_error(1 << 8, $$log_buf);
+        ref($res) eq 'ARRAY' or return $lei->child_error(0, $$log_buf);
         $lei->qerr($$log_buf);
         my ($git, $oid, $type, $size, $di) = @$res;
         my $oid_want = delete $self->{cur_oid_want};