about summary refs log tree commit homepage
path: root/lib/PublicInbox/LeiQuery.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-05-29 20:20:39 +0000
committerEric Wong <e@80x24.org>2021-05-30 05:02:42 +0000
commitc4aa366973c9129a640f51c6a52a986f393ac206 (patch)
tree7996b7ff793cf91b790ff4d26695b3ed85b4e348 /lib/PublicInbox/LeiQuery.pm
parent528d69bbbda3cd26d9cc317eff92d21d980b2056 (diff)
downloadpublic-inbox-c4aa366973c9129a640f51c6a52a986f393ac206.tar.gz
Saved searches rely on (reverse) docid ordering for efficient
incremental results, and sorting any other way prevents that.

Update comment description in LeiQuery while we're at it:
"ls-query" and "rm-query" are "ls-search" and "forget-search",
respectively, and "mv-query" is implicit with "edit-search"
Diffstat (limited to 'lib/PublicInbox/LeiQuery.pm')
-rw-r--r--lib/PublicInbox/LeiQuery.pm5
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/PublicInbox/LeiQuery.pm b/lib/PublicInbox/LeiQuery.pm
index 0435a516..eb7b98d4 100644
--- a/lib/PublicInbox/LeiQuery.pm
+++ b/lib/PublicInbox/LeiQuery.pm
@@ -1,7 +1,8 @@
 # Copyright (C) 2021 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 
-# handles lei <q|ls-query|rm-query|mv-query> commands
+# handles "lei q" command and provides internals for
+# several other sub-commands (up, lcat, ...)
 package PublicInbox::LeiQuery;
 use strict;
 use v5.10.1;
@@ -130,6 +131,8 @@ sub lei_q {
                 } else {
                         die "unrecognized --sort=$sort\n";
                 }
+                $opt->{save} and return
+                        $self->fail('--save and --sort are incompatible');
         }
         $self->{mset_opt} = \%mset_opt;