about summary refs log tree commit homepage
path: root/lib/PublicInbox/LeiOverview.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-02-02 22:11:37 -1000
committerEric Wong <e@80x24.org>2021-02-04 01:37:09 +0000
commit50c074ec9e030f05b53773dafb29d6098f58b56c (patch)
tree25b7e8f4716c6ff677d806855655a031edebaf4c /lib/PublicInbox/LeiOverview.pm
parentc7420334c0d69bf948ad670c822753334e4664a8 (diff)
downloadpublic-inbox-50c074ec9e030f05b53773dafb29d6098f58b56c.tar.gz
IO::Uncompress::Gunzip seems to be losing $? when closing
PublicInbox::ProcessPipe.  To workaround this, do a synchronous
waitpid ourselves to force proper $? reporting update tests to
use the new --only feature for testing invalid URLs.

This improves internal code consistency by having {pkt_op}
parse the same ASCII-only protocol script/lei understands.

We no longer pass {sock} to worker processes at all,
further reducing FD pressure on per-user limits.
Diffstat (limited to 'lib/PublicInbox/LeiOverview.pm')
-rw-r--r--lib/PublicInbox/LeiOverview.pm2
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm
index 366af8b2..88034ada 100644
--- a/lib/PublicInbox/LeiOverview.pm
+++ b/lib/PublicInbox/LeiOverview.pm
@@ -216,9 +216,7 @@ sub ovv_each_smsg_cb { # runs in wq worker usually
                         $wcb->(undef, $smsg, $eml);
                 };
         } elsif ($l2m && $l2m->{-wq_s1}) {
-                my $sock = delete $lei->{sock}; # lei2mail doesn't need it
                 my ($lei_ipc, @io) = $lei->atfork_parent_wq($l2m);
-                $lei->{sock} = $sock if $sock;
                 # $io[0] becomes a notification pipe that triggers EOF
                 # in this wq worker when all outstanding ->write_mail
                 # calls are complete