about summary refs log tree commit homepage
path: root/lib/PublicInbox/LeiOverview.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-01-13 19:06:15 -1200
committerEric Wong <e@80x24.org>2021-01-14 23:14:08 +0000
commit39d44555e3f04c97e98c7f5d3538bbba6a19656b (patch)
tree034da2d3634118b076b95e126f73f875795ddb3a /lib/PublicInbox/LeiOverview.pm
parent7dd5b28cb9bdcfa262ddad47d7f033f600675dc3 (diff)
downloadpublic-inbox-39d44555e3f04c97e98c7f5d3538bbba6a19656b.tar.gz
The new test ensures consistency between oneshot and
client/daemon users.  Cancelling an in-progress result now also
stops xsearch workers to avoid wasted CPU and I/O.

Note the lei->atfork_child_wq usage changes, it is to workaround
a bug in Perl 5: http://nntp.perl.org/group/perl.perl5.porters/258784
<CAHhgV8hPbcmkzWizp6Vijw921M5BOXixj4+zTh3nRS9vRBYk8w@mail.gmail.com>

This switches the internal protocol to use SOCK_SEQPACKET
AF_UNIX sockets to prevent merging messages from the daemon to
client to run pager and kill/exit the client script.
Diffstat (limited to 'lib/PublicInbox/LeiOverview.pm')
-rw-r--r--lib/PublicInbox/LeiOverview.pm5
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm
index 8a1f4f82..194c5e28 100644
--- a/lib/PublicInbox/LeiOverview.pm
+++ b/lib/PublicInbox/LeiOverview.pm
@@ -108,8 +108,9 @@ sub _unbless_smsg {
 
 sub ovv_atexit_child {
         my ($self, $lei) = @_;
-        my $bref = delete $lei->{ovv_buf} or return;
-        print { $lei->{1} } $$bref;
+        if (my $bref = delete $lei->{ovv_buf}) {
+                print { $lei->{1} } $$bref;
+        }
 }
 
 # JSON module ->pretty output wastes too much vertical white space,