about summary refs log tree commit homepage
path: root/lib/PublicInbox/LeiNoteEvent.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2022-04-21 11:59:06 +0000
committerEric Wong <e@80x24.org>2022-04-22 03:05:56 +0000
commit7e4bd71efcf3bf61216ec1a7577e33be5f95b8a9 (patch)
tree25569363d09dd1d047a2e8e158c1a5ccfd1a9e1d /lib/PublicInbox/LeiNoteEvent.pm
parentd362af89d8019ff12d3550c83de2c3aa5d9f095b (diff)
downloadpublic-inbox-7e4bd71efcf3bf61216ec1a7577e33be5f95b8a9.tar.gz
This change prevents lingering shard and git-fast-import
processes from remaining after interrupted "lei import" (and
similar).  It also reduces the likelyhood of data-loss in case
of subsequent abnormal termination of the daemon.

I think this is the least surprising way to handle users
prematurely aborting imports or other similar operations which
write to lei/store and will result in reduced bandwidth waste
for users with intermittent connections.  This is because the
lei/store processes may be shared by parallel "lei import"
callers, and commits done by any "lei import" caller will
inevitably trigger writes for all of them.
Diffstat (limited to 'lib/PublicInbox/LeiNoteEvent.pm')
-rw-r--r--lib/PublicInbox/LeiNoteEvent.pm4
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/PublicInbox/LeiNoteEvent.pm b/lib/PublicInbox/LeiNoteEvent.pm
index 22d6ffac..db387633 100644
--- a/lib/PublicInbox/LeiNoteEvent.pm
+++ b/lib/PublicInbox/LeiNoteEvent.pm
@@ -114,9 +114,7 @@ sub ipc_atfork_child {
 }
 
 sub _lei_wq_eof { # EOF callback for main lei daemon
-        my ($lei) = @_;
-        my $lne = delete $lei->{lne} or return $lei->fail;
-        $lei->sto_done_request($lne->{lei_sock});
+        $_[0]->wq_eof('lne');
 }
 
 1;