about summary refs log tree commit homepage
path: root/lib/PublicInbox/LeiInput.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-09-19 12:50:22 +0000
committerEric Wong <e@80x24.org>2021-09-19 19:52:45 +0000
commitcbc2890cb89b81cb6b9e8fabf3f196d9a6110dce (patch)
tree5e8fc56e04b6b52d28c5853aca1bb5f9b98f36b7 /lib/PublicInbox/LeiInput.pm
parent12775b5be53db1244b9cb32ae2ef90f105735e1b (diff)
downloadpublic-inbox-cbc2890cb89b81cb6b9e8fabf3f196d9a6110dce.tar.gz
This has several advantages:

* no need to use ipc.lock to protect a pipe for non-atomic writes

* ability to pass FDs.  In another commit, this will let us
  simplify lei->sto_done_request and pass newly-created
  sockets to lei/store directly.

disadvantages:

- an extra pipe is required for rare messages over several
  hundred KB, this is probably a non-issue, though

The performance delta is unknown, but I expect shards
(which remain pipes) to be the primary bottleneck IPC-wise
for lei/store.
Diffstat (limited to 'lib/PublicInbox/LeiInput.pm')
-rw-r--r--lib/PublicInbox/LeiInput.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/LeiInput.pm b/lib/PublicInbox/LeiInput.pm
index fe736981..22bedba6 100644
--- a/lib/PublicInbox/LeiInput.pm
+++ b/lib/PublicInbox/LeiInput.pm
@@ -378,7 +378,7 @@ sub process_inputs {
         }
         # always commit first, even on error partial work is acceptable for
         # lei <import|tag|convert>
-        my $wait = $self->{lei}->{sto}->ipc_do('done') if $self->{lei}->{sto};
+        my $wait = $self->{lei}->{sto}->wq_do('done') if $self->{lei}->{sto};
         $self->{lei}->fail($err) if $err;
 }