about summary refs log tree commit homepage
path: root/lib/PublicInbox/LeiExternal.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-02-10 07:07:48 +0000
committerEric Wong <e@80x24.org>2021-02-10 19:21:37 +0000
commitcb28429e2de5bd86dce66b3c5a1238e3e0985491 (patch)
tree3b3042c19b19cedddf59f47e09bb9e5738646364 /lib/PublicInbox/LeiExternal.pm
parent16e016a3dddce6e65c7b69e4f4fd4b7e65b9ccc7 (diff)
downloadpublic-inbox-cb28429e2de5bd86dce66b3c5a1238e3e0985491.tar.gz
I don't know if it's worth it to use libcurl directly
(nor the effort to support and maintain tests)
Diffstat (limited to 'lib/PublicInbox/LeiExternal.pm')
-rw-r--r--lib/PublicInbox/LeiExternal.pm3
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/PublicInbox/LeiExternal.pm b/lib/PublicInbox/LeiExternal.pm
index b402eed4..8a51afcb 100644
--- a/lib/PublicInbox/LeiExternal.pm
+++ b/lib/PublicInbox/LeiExternal.pm
@@ -44,6 +44,8 @@ sub ext_canonicalize {
         }
 }
 
+# TODO: we will probably extract glob2re into a separate module for
+# PublicInbox::Filter::Base and maybe other places
 my %re_map = ( '*' => '[^/]*?', '?' => '[^/]',
                 '[' => '[', ']' => ']', ',' => ',' );
 
@@ -99,6 +101,7 @@ sub get_externals {
         ();
 }
 
+# TODO: does this need JSON output?
 sub lei_ls_external {
         my ($self, $filter) = @_;
         my $opt = $self->{opt};