about summary refs log tree commit homepage
path: root/lib/PublicInbox/Import.pm
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-06-24 18:45:07 +0000
committerEric Wong <e@yhbt.net>2020-06-25 05:37:45 +0000
commitf977826a17f8735e6947dd2da380df8c6d0b38d8 (patch)
treea3879cdbfd7ba1ac32008173d163d8f5f4163fbb /lib/PublicInbox/Import.pm
parent7601f7d864d74dae58ee248e426527fb2ebe74a5 (diff)
downloadpublic-inbox-f977826a17f8735e6947dd2da380df8c6d0b38d8.tar.gz
We can reduce the amount of platform-specific code by always
relying on IN_MODIFY/NOTE_WRITE notifications from lock release.
This reduces the number of times our read-only daemons will
need to wake up when -watch sees no-op message changes
(e.g. replied, seen, recent flag changes).
Diffstat (limited to 'lib/PublicInbox/Import.pm')
-rw-r--r--lib/PublicInbox/Import.pm6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index af35905b..ae508cd8 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -468,9 +468,9 @@ sub done {
         waitpid($pid, 0) == $pid or die 'fast-import did not finish';
         $? == 0 or die "fast-import failed: $?";
 
-        _update_git_info($self, 1) if delete $self->{nchg};
-
-        $self->lock_release;
+        my $nchg = delete $self->{nchg};
+        _update_git_info($self, 1) if $nchg;
+        $self->lock_release(!!$nchg);
 
         $self->{git}->cleanup;
 }