diff options
author | Eric Wong <e@80x24.org> | 2023-11-02 09:35:30 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2023-11-03 06:39:28 +0000 |
commit | d3c55d072839286efb2865fe20f2324a9e595e95 (patch) | |
tree | c3a7b450e22a0e9d7e849d53884f6af8af19cee5 /lib/PublicInbox/Import.pm | |
parent | 19f9089343c9e579253db756f2131ee493718ead (diff) | |
download | public-inbox-d3c55d072839286efb2865fe20f2324a9e595e95.tar.gz |
treewide: use ->close to call ProcessIO->CLOSE
This will open the door for us to drop `tie' usage from ProcessIO completely in favor of OO method dispatch. While OO method dispatches (e.g. `$fh->close') are slower than normal subroutine calls, it hardly matters in this case since process teardown is a fairly rare operation and we continue to use `close($fh)' for Maildir writes.
Diffstat (limited to 'lib/PublicInbox/Import.pm')
-rw-r--r-- | lib/PublicInbox/Import.pm | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm index 6eee8774..e12a56e8 100644 --- a/lib/PublicInbox/Import.pm +++ b/lib/PublicInbox/Import.pm @@ -476,7 +476,7 @@ sub done { my $io = delete $self->{io} or return; eval { print $io "done\n" or wfail; - close $io; # reaps and dies on error + $io->close or croak "close fast-import \$?=$?"; # reaps }; my $wait_err = $@; my $nchg = delete $self->{nchg}; @@ -489,7 +489,7 @@ sub done { die $wait_err if $wait_err; } -sub atfork_child { close(delete($_[0]->{io}) // return) } +sub atfork_child { (delete($_[0]->{io}) // return)->close } sub digest2mid ($$;$) { my ($dig, $hdr, $fallback_time) = @_; @@ -598,7 +598,7 @@ sub replace_oids { push @buf, $_; } } - close $rd; + $rd->close or die "E: git @export (\$?=$?)"; if (@buf) { print $io @buf or wfail; } |