about summary refs log tree commit homepage
path: root/lib/PublicInbox/GitHTTPBackend.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2023-10-25 00:29:39 +0000
committerEric Wong <e@80x24.org>2023-10-25 07:28:42 +0000
commit3e634c22ceff4736d3c34d3496e7e5519e6ef356 (patch)
tree25472585f4c93917125b95457fbed3ee975cc2be /lib/PublicInbox/GitHTTPBackend.pm
parent6fe457251172f2f59a4e0a89be2a56913e88f2ad (diff)
downloadpublic-inbox-3e634c22ceff4736d3c34d3496e7e5519e6ef356.tar.gz
Now that psgi_yield is used everywhere, the more complex
psgi_return and it's helper bits can be removed.  We'll also fix
some outdated comments now that everything on psgi_return has
switched to psgi_yield.  GetlineResponse replaces GetlineBody
and does a better job of isolating generic PSGI-only code.
Diffstat (limited to 'lib/PublicInbox/GitHTTPBackend.pm')
-rw-r--r--lib/PublicInbox/GitHTTPBackend.pm6
1 files changed, 1 insertions, 5 deletions
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index d7e0bced..7228555b 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -145,16 +145,12 @@ sub parse_cgi_headers { # {parse_hdr} for Qspawn
                 }
         }
 
-        # fallback to WwwCoderepo if cgit 404s.  Duplicating $ctx prevents
-        # ->finalize from the current Qspawn from using qspawn.wcb.
-        # This makes qspawn skip ->async_pass and causes
-        # PublicInbox::HTTPD::Async::event_step to close shortly after
+        # fallback to WwwCoderepo if cgit 404s
         if ($code == 404 && $ctx->{www} && !$ctx->{_coderepo_tried}++) {
                 my $wcb = delete $ctx->{env}->{'qspawn.wcb'};
                 $ctx->{env}->{'plack.skip-deflater'} = 1; # prevent 2x gzip
                 $ctx->{env}->{'qspawn.fallback'} = $code;
                 my $res = $ctx->{www}->coderepo->srv($ctx);
-                # for ->psgi_return_init_cb
                 $ctx->{env}->{'qspawn.wcb'} = $wcb;
                 $res; # CODE or ARRAY ref
         } else {