diff options
| author | Eric Wong <e@80x24.org> | 2021-05-26 18:08:57 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2021-05-26 19:33:30 +0000 |
| commit | 1d6e1f9a6a66a42d18f109aea406237cf8571597 (patch) | |
| tree | 827b7465812239e9b4070eaa7162b33cabf42584 /lib/PublicInbox/GitCredential.pm | |
| parent | 708b182a57373172f5523f3dc297659d58e03b58 (diff) | |
| download | public-inbox-1d6e1f9a6a66a42d18f109aea406237cf8571597.tar.gz | |
The cost of supporting separate code paths between oneshot and
daemon isn't worth the trouble; especially if there are more
users to support. The test suite time nearly doubles with
oneshot, so that's hurting developer productivity.
FD passing is currently required to work efficiently with
remote HTTP(S) queries which return large messages, as seen in
commit 708b182a57373172f5523f3dc297659d58e03b58
("ipc: wq: handle >MAX_ARG_STRLEN && <EMSGSIZE case").
Additionally, upcoming support for IMAP IDLE and inotify-based
monitoring of Maildirs cannot work properly without a background
daemon.
Diffstat (limited to 'lib/PublicInbox/GitCredential.pm')
| -rw-r--r-- | lib/PublicInbox/GitCredential.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/GitCredential.pm b/lib/PublicInbox/GitCredential.pm index 2d81817c..b29780d6 100644 --- a/lib/PublicInbox/GitCredential.pm +++ b/lib/PublicInbox/GitCredential.pm @@ -9,7 +9,7 @@ sub run ($$;$) { my ($in_r, $in_w, $out_r); my $cmd = [ qw(git credential), $op ]; pipe($in_r, $in_w) or die "pipe: $!"; - if ($lei && !$lei->{oneshot}) { # we'll die if disconnected: + if ($lei) { # we'll die if disconnected: pipe($out_r, my $out_w) or die "pipe: $!"; $lei->send_exec_cmd([ $in_r, $out_w ], $cmd, {}); } else { |