www_stream: use DESTROY to cleanup temporary gits

Relying on a timer to handle cleanup in f9ac22a4b485 was
sub-optimal since the delay could prove expensive under heavy
traffic.  So rely on ->DESTROY instead since we we no longer
hold reference cycles by the time the show_blob callback
executes.

Fixes: f9ac22a4b485 ("git_async_cat: automatically cleanup temporary gits")

1 files changed, 0 insertions, 8 deletions

diff --git a/lib/PublicInbox/GitAsyncCat.pm b/lib/PublicInbox/GitAsyncCat.pm
index 2d601542..b32c2fd3 100644
--- a/lib/PublicInbox/GitAsyncCat.pm
+++ b/lib/PublicInbox/GitAsyncCat.pm
@@ -45,12 +45,6 @@ sub event_step {
         }
 }
 
-sub git_tmp_cleanup {
-        my ($git) = @_;
-        $git->cleanup(1) and
-                PublicInbox::DS::add_timer(3, \&git_tmp_cleanup, $git);
-}
-
 sub ibx_async_cat ($$$$) {
         my ($ibx, $oid, $cb, $arg) = @_;
         my $git = $ibx->{git} // $ibx->git;
@@ -69,8 +63,6 @@ sub ibx_async_cat ($$$$) {
                 $git->{async_cat} //= do {
                         my $self = bless { git => $git }, __PACKAGE__;
                         $git->{in}->blocking(0);
-                        $git->{-tmp} and PublicInbox::DS::add_uniq_timer(
-                                                3, \&git_tmp_cleanup, $git);
                         $self->SUPER::new($git->{in}, EPOLLIN|EPOLLET);
                         \undef; # this is a true ref()
                 };