treewide: update read_all to avoid eof|close checks

read_all can be expanded to support FIFOs/pipes/sockets where
read-until-EOF behavior is desired.  We can also rely on
wantarray to support splitting on EOL markers, but it's
hard-coded to support only `$/ eq "\n"' since (AFAIK)
it's the only way we use the wantarray form `readline'.

1 files changed, 1 insertions, 2 deletions

diff --git a/lib/PublicInbox/Gcf2.pm b/lib/PublicInbox/Gcf2.pm
index 5490049d..e0219b55 100644
--- a/lib/PublicInbox/Gcf2.pm
+++ b/lib/PublicInbox/Gcf2.pm
@@ -81,8 +81,7 @@ sub add_alt ($$) {
         #
         # See https://bugs.debian.org/975607
         if (open(my $fh, '<', "$objdir/info/alternates")) {
-                chomp(my @abs_alt = grep(m!^/!, <$fh>));
-                $fh = eof($fh) | close $fh; # detect readline errors
+                chomp(my @abs_alt = grep m!^/!, PublicInbox::IO::read_all $fh);
                 $gcf2->add_alternate($_) for @abs_alt;
         }
         $gcf2->add_alternate($objdir);