about summary refs log tree commit homepage
path: root/lib/PublicInbox/Filter/Base.pm
diff options
authorEric Wong <e@80x24.org>2018-04-19 22:42:05 +0000
committerEric Wong <e@80x24.org>2018-04-19 22:43:03 +0000
commitddb61e55bc645975063673f346fceb96be7b2d70 (patch)
tree67e0a446c890d113e8a28d593a0777c4256ed418 /lib/PublicInbox/Filter/Base.pm
parent03c7d76f08b78d43452463d95dcf3a38fb9c8bfe (diff)
I suppose it's a bug or inconsistency that altid is write-only
and their deletions do not get reflected.  But for now, we
do not set it when training spam so there's no window where
an invalid NNTP article number shows up.

This should solve the problem where there's massive gaps
in messages solved by spam training for ruby groups:

Diffstat (limited to 'lib/PublicInbox/Filter/Base.pm')
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/PublicInbox/Filter/Base.pm b/lib/PublicInbox/Filter/Base.pm
index 5d070132..638b627a 100644
--- a/lib/PublicInbox/Filter/Base.pm
+++ b/lib/PublicInbox/Filter/Base.pm
@@ -66,9 +66,10 @@ sub reject ($$) {
 sub err ($) { $_[0]->{err} }
 # by default, scrub is a no-op, see PublicInbox::Filter::Vger::scrub
-# for an example of the override
+# for an example of the override.  The $for_remove arg is set to
+# disable altid setting for spam removal.
 sub scrub {
-        my ($self, $mime) = @_;
+        my ($self, $mime, $for_remove) = @_;