clone+fetch: respect umask for all downloaded files

Since public inboxes are usually intended to be public,
the File::Temp default permission of 0600 is wrong.
Just respect the user's umask in this case as git-clone
does.

This doesn't work for "lei add-external --mirror", yet;
but it will...

1 files changed, 2 insertions, 3 deletions

diff --git a/lib/PublicInbox/Fetch.pm b/lib/PublicInbox/Fetch.pm
index 0d4badbf..5261cad1 100644
--- a/lib/PublicInbox/Fetch.pm
+++ b/lib/PublicInbox/Fetch.pm
@@ -218,13 +218,12 @@ EOM
         }
         for my $i (@new_epoch) { $mg->epoch_cfg_set($i) }
         if ($ft) {
-                my $fn = $ft->filename;
                 if ($mculled) {
                         my $json = PublicInbox::Config->json->encode($m1);
+                        my $fn = $ft->filename;
                         gzip(\$json => $fn) or die "gzip: $GzipError";
                 }
-                rename($fn, $mf) or die "E: rename($fn, $mf): $!\n";
-                $ft->unlink_on_destroy(0);
+                PublicInbox::LeiMirror::ft_rename($ft, $mf, 0666);
         }
         $lei->child_error($xit << 8) if $fp2 && $xit;
 }