diff options
author | Štěpán Němec <stepnem@smrk.net> | 2023-08-28 12:42:42 +0200 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2023-08-28 21:32:27 +0000 |
commit | 376d71e65320b50a81093fa6047b475efc7c2395 (patch) | |
tree | 2b3f5fcf37077c3ba5b1b2799febb17bcfc7a67c /ci | |
parent | a036772bdf732d4779f44974095bfdd0b30271ef (diff) | |
download | public-inbox-376d71e65320b50a81093fa6047b475efc7c2395.tar.gz |
'-' could never match, remove that alternative (it might have been a typo of '--', but that is already covered by '*--|--*' ('*' matches the null string)). Replace '*--*' with the equivalent '*' ('--' is always present). It would seem clearer to just replace the whole case command with something like '[ "$ID" -a "$VERSION_ID" ] && break' (or the POSIX-non-deprecated equivalent '[ "$ID" ] && [ "$VERSION_ID" ]' ); I assume a preference of using case here (e.g., to avoid syscall overhead in case [ is not implemented as a shell builtin (which seems far-fetched given the context, though)).
Diffstat (limited to 'ci')
-rwxr-xr-x | ci/profiles.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ci/profiles.sh b/ci/profiles.sh index 3cd8fa38..e58b61d5 100755 --- a/ci/profiles.sh +++ b/ci/profiles.sh @@ -30,8 +30,8 @@ GNU/Linux) esac case $ID--$VERSION_ID in - -|*--|--*) continue ;; - *--*) break ;; + *--|--*) continue ;; + *) break ;; esac done ;; |