From: "Nicolás Ojeda Bär" <n.oje.bar@gmail.com>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [BUG] public-inbox-httpd: messages without subject are not viewable
Date: Wed, 14 Mar 2018 11:04:15 +0100 [thread overview]
Message-ID: <CAPunWhCAOTd8GbgP7peSbP7JFp_vhDj=h0AizM5pnz+G-G1C4g@mail.gmail.com> (raw)
In-Reply-To: <20180314072115.GA20875@dcvr>
On Wed, Mar 14, 2018 at 8:21 AM, Eric Wong <e@80x24.org> wrote:
> Nicolás Ojeda Bär <n.oje.bar@gmail.com> wrote:
>> Hello,
>>
>> When browsing messages in the web interface, there is no link
>> displayed for messages without subject. Using a "(no subject)" dummy
>> subject like in the git repository would work well enough.
>
> The following probably does it (untested).
>
> diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
> index 590a76a..b8b2a5f 100644
> --- a/lib/PublicInbox/View.pm
> +++ b/lib/PublicInbox/View.pm
> @@ -966,6 +966,7 @@ sub dump_topics {
> obfuscate_addrs($obfs_ibx, $subj) if $obfs_ibx;
> $href = mid_escape($mid);
> $s .= indent_for($level) . TCHILD;
> + $subj = '(no subject)' if $subj eq '';
> $s .= "<a\nhref=\"$href/T/#u\">$subj</a>$omit\n";
> }
> push @out, $s;
Thanks, I will try it out.
Nicolás
prev parent reply other threads:[~2018-03-14 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 9:19 [BUG] public-inbox-httpd: messages without subject are not viewable Nicolás Ojeda Bär
2018-03-14 7:21 ` Eric Wong
2018-03-14 10:04 ` Nicolás Ojeda Bär [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPunWhCAOTd8GbgP7peSbP7JFp_vhDj=h0AizM5pnz+G-G1C4g@mail.gmail.com' \
--to=n.oje.bar@gmail.com \
--cc=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).