From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <n.oje.bar@gmail.com>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS3215 2.6.0.0/16
X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0
Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id 71D951FAE2
	for <meta@public-inbox.org>; Wed, 14 Mar 2018 10:30:27 +0000 (UTC)
Received: by mail-io0-x234.google.com with SMTP id d21so3765878ioc.5
        for <meta@public-inbox.org>; Wed, 14 Mar 2018 03:30:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=m0d/5xdqS5UjnwZ0Rt9m7aDIUTLUmD16Wo9hKPj6WPI=;
        b=A5kv7gafVs/E0rkXbnxJxV4mj0s/6BK14qq33CRTH8R7Jn2ZLbYBCQBh2ViERXWOHn
         R3hF7nRMBnwN2r1xU2zGgoFOs+/0yt+4ZxSA/Y0f9hWUVz8hcPeAMhT4gbFrKApmhgzr
         BfebwbWKyqHo09yKRoc5ci4uLm3/sIWPWFZo3JfrL1nSZULOu6jvwgilJ2kXk39Kfwhk
         eGEpg0EqY+mq+9fcdXXa9GTM65S0xAE4+uGgP9ebp+M2UJqmqrZQpa7oYIVSLklUcoc0
         z9XKHPH+99tSIrBmlw95MAjgc/w4KZWq3V+iVKNUzR3PLrqOepU/uliXBnBlZdp9C8cM
         E/Gw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=m0d/5xdqS5UjnwZ0Rt9m7aDIUTLUmD16Wo9hKPj6WPI=;
        b=jPQ+7AnlbSF3qod6uiHLd0mhzNx3VKib6QHhqVM/YrlLPhozUcaPNtfNA8aQh33EFU
         hvsFrfMQ6CWlmrHHds2aE9YsS5LQnPsvXvU/WxSK4ysa3vF4GV39b1ddP2zqHYvTSc1w
         PSr1191RUO53jo6rsnLyWmpezQ44gMcI2nYtjiLMuXthAwYWcJ68FVUhWbgijGPspT4w
         +gOibffFnjhGxHrWijO5L3+9o5skoejklQCt0gbG8xKKY9sq+lwQaGylE7raIg+UrI1X
         Kq9IKD9i4XJAP7mQ+OiQ3QkWiOYn1Xj994htD8u8kSvzvu4wmaWlvEnSXHTssJcwENWJ
         95ZQ==
X-Gm-Message-State: AElRT7FaMW2KLimDv3VyT1/iVTgyUooM6vz9E8QGf1fnA5QHz1GOGZ4p
	ueDCPjZu547EMIZ8QBKIQvXAVCPp/0b70omiAyA=
X-Google-Smtp-Source: AG47ELtaWwLBnFFsz3YaGBIUIYkzRIfYzBbBPWyccP9YK/umuOJkCJBrNrJFyEARjrjQqAH1DtQwDrYONRMD70Eh6gk=
X-Received: by 10.107.202.67 with SMTP id a64mr4268939iog.194.1521021856257;
 Wed, 14 Mar 2018 03:04:16 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.79.209.242 with HTTP; Wed, 14 Mar 2018 03:04:15 -0700 (PDT)
In-Reply-To: <20180314072115.GA20875@dcvr>
References: <CAPunWhDE+-Fw2XGphtdPgDPrbM7zLdiqP2mxt7LMJJjgLNFDEA@mail.gmail.com>
 <20180314072115.GA20875@dcvr>
From: =?UTF-8?Q?Nicol=C3=A1s_Ojeda_B=C3=A4r?= <n.oje.bar@gmail.com>
Date: Wed, 14 Mar 2018 11:04:15 +0100
Message-ID: <CAPunWhCAOTd8GbgP7peSbP7JFp_vhDj=h0AizM5pnz+G-G1C4g@mail.gmail.com>
Subject: Re: [BUG] public-inbox-httpd: messages without subject are not viewable
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <meta.public-inbox.org>

On Wed, Mar 14, 2018 at 8:21 AM, Eric Wong <e@80x24.org> wrote:
> Nicol=C3=A1s Ojeda B=C3=A4r <n.oje.bar@gmail.com> wrote:
>> Hello,
>>
>> When browsing messages in the web interface, there is no link
>> displayed for messages without subject. Using a "(no subject)" dummy
>> subject like in the git repository would work well enough.
>
> The following probably does it (untested).
>
> diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
> index 590a76a..b8b2a5f 100644
> --- a/lib/PublicInbox/View.pm
> +++ b/lib/PublicInbox/View.pm
> @@ -966,6 +966,7 @@ sub dump_topics {
>                         obfuscate_addrs($obfs_ibx, $subj) if $obfs_ibx;
>                         $href =3D mid_escape($mid);
>                         $s .=3D indent_for($level) . TCHILD;
> +                       $subj =3D '(no subject)' if $subj eq '';
>                         $s .=3D "<a\nhref=3D\"$href/T/#u\">$subj</a>$omit=
\n";
>                 }
>                 push @out, $s;

Thanks, I will try it out.

Nicol=C3=A1s