* [PATCH 5/7] www: remove footer_html support
2016-05-28 1:57 7% [PATCH 0/7] miscellaneous cleanups Eric Wong
@ 2016-05-28 1:57 6% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-05-28 1:57 UTC (permalink / raw)
To: meta
I haven't used it in a while and the existing "description"
is probably good enough.
If we support it again, it should be plain-text + auto-linkified
for ease-of-maintenance and consistency.
---
lib/PublicInbox/Inbox.pm | 10 ----------
lib/PublicInbox/WWW.pm | 2 --
2 files changed, 12 deletions(-)
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 4bcab96..c07aaa9 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -64,16 +64,6 @@ sub cloneurl {
$self->{cloneurl} = \@url;
}
-# TODO: can we remove this?
-sub footer_html {
- my ($self) = @_;
- my $footer = $self->{footer};
- return $footer if defined $footer;
- $footer = try_cat("$self->{mainrepo}/public-inbox/footer.html");
- chomp $footer;
- $self->{footer} = $footer;
-}
-
sub base_url {
my ($self, $prq) = @_; # Plack::Request
if (defined $prq) {
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index 5b4d6c1..e8f1fbf 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -252,8 +252,6 @@ sub footer {
my ($ctx) = @_;
return '' unless $ctx;
my $obj = $ctx->{-inbox} or return '';
- my $footer = $obj->footer_html;
- return $ctx->{footer} = $footer if $footer;
# auto-generate a footer
chomp(my $desc = $obj->description);
--
EW
^ permalink raw reply related [relevance 6%]
* [PATCH 0/7] miscellaneous cleanups
@ 2016-05-28 1:57 7% Eric Wong
2016-05-28 1:57 6% ` [PATCH 5/7] www: remove footer_html support Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2016-05-28 1:57 UTC (permalink / raw)
To: meta
Only the last one (NewsGroup class removal for ::Inbox) is
likely to cause problems but I'll be checking logs for
errors.
Eric Wong (7):
t/plack: ensure we can cascade on common endpoints
http: clarify comments about layering violation
Makefile.PL: allow N to be overridden
examples: config no longer supports atomUrl
www: remove footer_html support
config: remove try_cat
remove redundant NewsGroup class
MANIFEST | 1 -
Makefile.PL | 2 +-
examples/public-inbox-config | 1 -
lib/PublicInbox/Config.pm | 49 +++++++++++++++-----------
lib/PublicInbox/HTTP.pm | 6 ++--
lib/PublicInbox/Inbox.pm | 17 ++++-----
lib/PublicInbox/NNTP.pm | 9 ++---
lib/PublicInbox/NNTPD.pm | 27 ++++----------
lib/PublicInbox/NewsGroup.pm | 84 --------------------------------------------
lib/PublicInbox/NewsWWW.pm | 38 ++------------------
lib/PublicInbox/WWW.pm | 6 ++--
t/config.t | 2 ++
t/nntp.t | 15 +++++---
t/nntpd.t | 4 ++-
t/plack.t | 12 +++++--
15 files changed, 83 insertions(+), 190 deletions(-)
^ permalink raw reply [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-05-28 1:57 7% [PATCH 0/7] miscellaneous cleanups Eric Wong
2016-05-28 1:57 6% ` [PATCH 5/7] www: remove footer_html support Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).