From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 5/7] www: remove footer_html support
Date: Sat, 28 May 2016 01:57:12 +0000 [thread overview]
Message-ID: <20160528015714.1325-6-e@80x24.org> (raw)
In-Reply-To: <20160528015714.1325-1-e@80x24.org>
I haven't used it in a while and the existing "description"
is probably good enough.
If we support it again, it should be plain-text + auto-linkified
for ease-of-maintenance and consistency.
---
lib/PublicInbox/Inbox.pm | 10 ----------
lib/PublicInbox/WWW.pm | 2 --
2 files changed, 12 deletions(-)
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 4bcab96..c07aaa9 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -64,16 +64,6 @@ sub cloneurl {
$self->{cloneurl} = \@url;
}
-# TODO: can we remove this?
-sub footer_html {
- my ($self) = @_;
- my $footer = $self->{footer};
- return $footer if defined $footer;
- $footer = try_cat("$self->{mainrepo}/public-inbox/footer.html");
- chomp $footer;
- $self->{footer} = $footer;
-}
-
sub base_url {
my ($self, $prq) = @_; # Plack::Request
if (defined $prq) {
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index 5b4d6c1..e8f1fbf 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -252,8 +252,6 @@ sub footer {
my ($ctx) = @_;
return '' unless $ctx;
my $obj = $ctx->{-inbox} or return '';
- my $footer = $obj->footer_html;
- return $ctx->{footer} = $footer if $footer;
# auto-generate a footer
chomp(my $desc = $obj->description);
--
EW
next prev parent reply other threads:[~2016-05-28 1:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 1:57 [PATCH 0/7] miscellaneous cleanups Eric Wong
2016-05-28 1:57 ` [PATCH 1/7] t/plack: ensure we can cascade on common endpoints Eric Wong
2016-05-28 1:57 ` [PATCH 2/7] http: clarify comments about layering violation Eric Wong
2016-05-28 1:57 ` [PATCH 3/7] Makefile.PL: allow N to be overridden Eric Wong
2016-05-28 1:57 ` [PATCH 4/7] examples: config no longer supports atomUrl Eric Wong
2016-05-28 1:57 ` Eric Wong [this message]
2016-05-28 1:57 ` [PATCH 6/7] config: remove try_cat Eric Wong
2016-05-28 1:57 ` [PATCH 7/7] remove redundant NewsGroup class Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160528015714.1325-6-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).