* [PATCH 6/7] viewvcs: drop pointless variable assignment
@ 2022-08-22 2:33 5% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2022-08-22 2:33 UTC (permalink / raw)
To: meta
Not needed since commit:
41f03a3bd4b13dfa (viewvcs: do not show final error message twice, 2019-01-27)
---
lib/PublicInbox/ViewVCS.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index d3fd152d..94656ad3 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -114,13 +114,12 @@ sub solve_result {
}
$log = do { local $/; <$log> };
- my $ref = ref($res);
my $l = PublicInbox::Linkify->new;
$log = '<pre>debug log:</pre><hr /><pre>' .
$l->to_html($log) . '</pre>';
$res or return html_page($ctx, 404, \$log);
- $ref eq 'ARRAY' or return html_page($ctx, 500, \$log);
+ ref($res) eq 'ARRAY' or return html_page($ctx, 500, \$log);
my ($git, $oid, $type, $size, $di) = @$res;
return show_other($ctx, $res, \$log, $fn) if $type ne 'blob';
^ permalink raw reply related [relevance 5%]
* [PATCH 13/14] viewvcs: do not show final error message twice
2019-01-27 4:03 4% [PATCH 00/14] convert solver to use pi-httpd.async Eric Wong
@ 2019-01-27 4:03 7% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2019-01-27 4:03 UTC (permalink / raw)
To: meta
SolverGit::ERR already writes the exception to the debug
log before calling {user_cb}, so there's no need for viewvcs
to append it.
---
lib/PublicInbox/ViewVCS.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index fa76086..5de37ee 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -46,7 +46,6 @@ sub solve_result {
$log = do { local $/; <$log> };
my $ref = ref($res);
- $log .= $res unless $ref;
my $l = PublicInbox::Linkify->new;
$l->linkify_1($log);
$log = '<pre>debug log:</pre><hr /><pre>' .
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 00/14] convert solver to use pi-httpd.async
@ 2019-01-27 4:03 4% Eric Wong
2019-01-27 4:03 7% ` [PATCH 13/14] viewvcs: do not show final error message twice Eric Wong
0 siblings, 1 reply; 3+ results
From: Eric Wong @ 2019-01-27 4:03 UTC (permalink / raw)
To: meta
Much of the groundwork for this was laid in the now-abandoned
"repobrowse" branch. The goal was to improves fairness as we no
longer wait synchronously on git (apply|update-index|ls-files)
processes and can requests for other clients.
The end result was slightly (2-3%?) slower with all the
callbacks, but reducing "git apply" invocations by relying on
pathnames (instead of stdin) made the end result ~20% faster for
a large (64) patch series.
Email::Simple (via Email::MIME/PublicInbox::MIME) remains a
performance bottleneck, as it does a lot of unnecessary header
parsing and hash-table populating we don't care about; but I'm
not sure if I'll have time to address that.
Eric Wong (14):
httpd/async: remove needless sysread wrapper
qspawn: implement psgi_return and use it for githttpbackend
qspawn|getlinebody: support streaming filters
qspawn|httpd/async: improve and fix out-of-date comments
httpd/async: stop running command if client disconnects
qspawn: implement psgi_qx
t/qspawn.t: psgi_qx stderr test
view: swap CRLF for LF in HTML output
solver: rewrite to use Qspawn->psgi_qx and pi-httpd.async
solver: hold patches in temporary directory
solver: reduce "git apply" invocations
qspawn: decode $? for user-friendliness
viewvcs: do not show final error message twice
solver: crank up max patches to 9999
lib/PublicInbox/GetlineBody.pm | 16 +-
lib/PublicInbox/Git.pm | 2 +-
lib/PublicInbox/GitHTTPBackend.pm | 64 +---
lib/PublicInbox/HTTPD/Async.pm | 27 +-
lib/PublicInbox/Qspawn.pm | 143 +++++++-
lib/PublicInbox/SolverGit.pm | 532 +++++++++++++++++-------------
lib/PublicInbox/View.pm | 4 +
lib/PublicInbox/ViewVCS.pm | 50 ++-
t/qspawn.t | 12 +-
t/solver_git.t | 22 +-
10 files changed, 543 insertions(+), 329 deletions(-)
--
EW
^ permalink raw reply [relevance 4%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-01-27 4:03 4% [PATCH 00/14] convert solver to use pi-httpd.async Eric Wong
2019-01-27 4:03 7% ` [PATCH 13/14] viewvcs: do not show final error message twice Eric Wong
2022-08-22 2:33 [PATCH 0/7] an even bigger git show than before Eric Wong
2022-08-22 2:33 5% ` [PATCH 6/7] viewvcs: drop pointless variable assignment Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).