From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 3F64D1F61F for ; Mon, 22 Aug 2022 02:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1661135627; bh=Wr2kFoLsYDcoP95z/Gts1UoAC9n28KOgcA6d2bo9nMk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=HXvRabR1LajWunzU7PKgJ/x0rqs7swCW0b5iLO3Np7+Vb4AImmwFETvLkVNAJXoBb NV10ZsVrhuCVadajyxoIdUah/JwJXiFxPWjwlQZL+S/JRUCZg2aymBimAL06HKf4cy qg/5DUWMfm2lz3J0l3hnNTCdd7b7GR5KfSfVpUeI= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 6/7] viewvcs: drop pointless variable assignment Date: Mon, 22 Aug 2022 02:33:45 +0000 Message-Id: <20220822023346.938859-7-e@80x24.org> In-Reply-To: <20220822023346.938859-1-e@80x24.org> References: <20220822023346.938859-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Not needed since commit: 41f03a3bd4b13dfa (viewvcs: do not show final error message twice, 2019-01-27) --- lib/PublicInbox/ViewVCS.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index d3fd152d..94656ad3 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -114,13 +114,12 @@ sub solve_result { } $log = do { local $/; <$log> }; - my $ref = ref($res); my $l = PublicInbox::Linkify->new; $log = '
debug log:
' .
 		$l->to_html($log) . '
'; $res or return html_page($ctx, 404, \$log); - $ref eq 'ARRAY' or return html_page($ctx, 500, \$log); + ref($res) eq 'ARRAY' or return html_page($ctx, 500, \$log); my ($git, $oid, $type, $size, $di) = @$res; return show_other($ctx, $res, \$log, $fn) if $type ne 'blob';