* [PATCH] view: correctly pick latest in index anchor links
@ 2015-10-01 5:59 7% Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2015-10-01 5:59 UTC (permalink / raw)
To: meta
The last message in a thread _display_ is not necessarily the
latest message in the thread. We must go by the Date: header
on the messages themselves as a best-guess. Of course Date:
headers may lie, but most mail clients trust them by default,
so we will, too.
---
lib/PublicInbox/View.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 07023e8..ccdcde2 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -823,7 +823,10 @@ sub add_topic {
my $u = $x->header('X-PI-From');
my $ts = $x->header('X-PI-TS');
- $state->{latest}->{$topic} = [ $mid, $u, $ts ];
+ my $exist = $state->{latest}->{$topic};
+ if (!$exist || $exist->[2] < $ts) {
+ $state->{latest}->{$topic} = [ $mid, $u, $ts ];
+ }
} else {
# ghost message, do not bump level
$child_adjust = 0;
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-10-01 5:59 7% [PATCH] view: correctly pick latest in index anchor links Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).