user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: correctly pick latest in index anchor links
Date: Thu,  1 Oct 2015 05:59:20 +0000	[thread overview]
Message-ID: <20151001055920.11639-1-e@80x24.org> (raw)

The last message in a thread _display_ is not necessarily the
latest message in the thread.  We must go by the Date: header
on the messages themselves as a best-guess.  Of course Date:
headers may lie, but most mail clients trust them by default,
so we will, too.
---
 lib/PublicInbox/View.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 07023e8..ccdcde2 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -823,7 +823,10 @@ sub add_topic {
 
 		my $u = $x->header('X-PI-From');
 		my $ts = $x->header('X-PI-TS');
-		$state->{latest}->{$topic} = [ $mid, $u, $ts ];
+		my $exist = $state->{latest}->{$topic};
+		if (!$exist || $exist->[2] < $ts) {
+			$state->{latest}->{$topic} = [ $mid, $u, $ts ];
+		}
 	} else {
 		# ghost message, do not bump level
 		$child_adjust = 0;
-- 
EW


                 reply	other threads:[~2015-10-01  5:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151001055920.11639-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).