* [PATCH 1/8] v2: use v5.10.1, parent.pm, drop warnings
2020-07-17 6:31 6% [PATCH 0/8] indexing cleanup and code reduction Eric Wong
@ 2020-07-17 6:31 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-07-17 6:31 UTC (permalink / raw)
To: meta
The "5.010_001" form was for Perl 5.6, which I doubt anybody
would attempt; so favor "v5.10.1" as it is more readable to
humans. Prefer "parent" to "base" since the former is lighter.
We'll also rely on warnings from "-w" globally (or not) instead
of via "use".
We'll also update "use" statements to reflect what's actually
used by V2Writable.
---
lib/PublicInbox/SearchIdxShard.pm | 4 ++--
lib/PublicInbox/V2Writable.pm | 7 +++----
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/SearchIdxShard.pm b/lib/PublicInbox/SearchIdxShard.pm
index f7ba293f..baf7352a 100644
--- a/lib/PublicInbox/SearchIdxShard.pm
+++ b/lib/PublicInbox/SearchIdxShard.pm
@@ -5,8 +5,8 @@
# See L<public-inbox-v2-format(5)> for more info on how we shard Xapian
package PublicInbox::SearchIdxShard;
use strict;
-use warnings;
-use base qw(PublicInbox::SearchIdx);
+use v5.10.1;
+use parent qw(PublicInbox::SearchIdx);
use IO::Handle (); # autoflush
use PublicInbox::Eml;
diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index 528f5e9a..0119ea76 100644
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -5,16 +5,15 @@
# Used to write to V2 inboxes (see L<public-inbox-v2-format(5)>).
package PublicInbox::V2Writable;
use strict;
-use warnings;
-use base qw(PublicInbox::Lock);
-use 5.010_001;
+use v5.10.1;
+use parent qw(PublicInbox::Lock);
use PublicInbox::SearchIdxShard;
use PublicInbox::Eml;
use PublicInbox::Git;
use PublicInbox::Import;
use PublicInbox::MID qw(mids references);
use PublicInbox::ContentHash qw(content_hash content_digest);
-use PublicInbox::Inbox;
+use PublicInbox::InboxWritable;
use PublicInbox::OverIdx;
use PublicInbox::Msgmap;
use PublicInbox::Spawn qw(spawn popen_rd);
^ permalink raw reply related [relevance 7%]
* [PATCH 0/8] indexing cleanup and code reduction
@ 2020-07-17 6:31 6% Eric Wong
2020-07-17 6:31 7% ` [PATCH 1/8] v2: use v5.10.1, parent.pm, drop warnings Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-07-17 6:31 UTC (permalink / raw)
To: meta
Some bigger indexing updates coming, but first we can
reduce allocations and get rid of some overly complicated
unindexing logic.
Eric Wong (8):
v2: use v5.10.1, parent.pm, drop warnings
drop binmode usage
import: use common capitalization for filtering headers
with_umask: pass args to callback
overidx: each_by_mid: pass self and args to callbacks
overidx: favor non-OO sub dispatch for internal subs
searchidx: use v5.10.1, parent.pm, drop warnings
search: simplify unindexing
lib/PublicInbox/Import.pm | 4 +-
lib/PublicInbox/InboxWritable.pm | 42 ++++---
lib/PublicInbox/OverIdx.pm | 126 +++++++++++----------
lib/PublicInbox/SearchIdx.pm | 178 ++++++++++++------------------
lib/PublicInbox/SearchIdxShard.pm | 12 +-
lib/PublicInbox/V2Writable.pm | 116 +++++++++----------
lib/PublicInbox/Xapcmd.pm | 35 +++---
t/search.t | 6 +-
8 files changed, 246 insertions(+), 273 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-07-17 6:31 6% [PATCH 0/8] indexing cleanup and code reduction Eric Wong
2020-07-17 6:31 7% ` [PATCH 1/8] v2: use v5.10.1, parent.pm, drop warnings Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).