From: Eric Wong <e@yhbt.net> To: meta@public-inbox.org Subject: [PATCH 1/8] v2: use v5.10.1, parent.pm, drop warnings Date: Fri, 17 Jul 2020 06:31:48 +0000 [thread overview] Message-ID: <20200717063155.3734-2-e@yhbt.net> (raw) In-Reply-To: <20200717063155.3734-1-e@yhbt.net> The "5.010_001" form was for Perl 5.6, which I doubt anybody would attempt; so favor "v5.10.1" as it is more readable to humans. Prefer "parent" to "base" since the former is lighter. We'll also rely on warnings from "-w" globally (or not) instead of via "use". We'll also update "use" statements to reflect what's actually used by V2Writable. --- lib/PublicInbox/SearchIdxShard.pm | 4 ++-- lib/PublicInbox/V2Writable.pm | 7 +++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/PublicInbox/SearchIdxShard.pm b/lib/PublicInbox/SearchIdxShard.pm index f7ba293f..baf7352a 100644 --- a/lib/PublicInbox/SearchIdxShard.pm +++ b/lib/PublicInbox/SearchIdxShard.pm @@ -5,8 +5,8 @@ # See L<public-inbox-v2-format(5)> for more info on how we shard Xapian package PublicInbox::SearchIdxShard; use strict; -use warnings; -use base qw(PublicInbox::SearchIdx); +use v5.10.1; +use parent qw(PublicInbox::SearchIdx); use IO::Handle (); # autoflush use PublicInbox::Eml; diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm index 528f5e9a..0119ea76 100644 --- a/lib/PublicInbox/V2Writable.pm +++ b/lib/PublicInbox/V2Writable.pm @@ -5,16 +5,15 @@ # Used to write to V2 inboxes (see L<public-inbox-v2-format(5)>). package PublicInbox::V2Writable; use strict; -use warnings; -use base qw(PublicInbox::Lock); -use 5.010_001; +use v5.10.1; +use parent qw(PublicInbox::Lock); use PublicInbox::SearchIdxShard; use PublicInbox::Eml; use PublicInbox::Git; use PublicInbox::Import; use PublicInbox::MID qw(mids references); use PublicInbox::ContentHash qw(content_hash content_digest); -use PublicInbox::Inbox; +use PublicInbox::InboxWritable; use PublicInbox::OverIdx; use PublicInbox::Msgmap; use PublicInbox::Spawn qw(spawn popen_rd);
next prev parent reply other threads:[~2020-07-17 6:31 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-17 6:31 [PATCH 0/8] indexing cleanup and code reduction Eric Wong 2020-07-17 6:31 ` Eric Wong [this message] 2020-07-17 6:31 ` [PATCH 2/8] drop binmode usage Eric Wong 2020-07-17 6:31 ` [PATCH 3/8] import: use common capitalization for filtering headers Eric Wong 2020-07-17 6:31 ` [PATCH 4/8] with_umask: pass args to callback Eric Wong 2020-07-17 6:31 ` [PATCH 5/8] overidx: each_by_mid: pass self and args to callbacks Eric Wong 2020-07-17 6:31 ` [PATCH 6/8] overidx: favor non-OO sub dispatch for internal subs Eric Wong 2020-07-17 6:31 ` [PATCH 7/8] searchidx: use v5.10.1, parent.pm, drop warnings Eric Wong 2020-07-17 6:31 ` [PATCH 8/8] search: simplify unindexing Eric Wong 2020-07-17 7:25 ` [9/8 PATCH] v2writable: git_hash_raw: avoid $TMPDIR write Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200717063155.3734-2-e@yhbt.net \ --to=e@yhbt.net \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 1/8] v2: use v5.10.1, parent.pm, drop warnings' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).