* [PATCH] unsubscribe: archive_url may be undefined
@ 2016-06-15 21:12 7% Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-06-15 21:12 UTC (permalink / raw)
To: meta
We'll show a nasty warning in the UI instead of triggering
a perl warning about an undefined variable.
---
lib/PublicInbox/Unsubscribe.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Unsubscribe.pm b/lib/PublicInbox/Unsubscribe.pm
index 239feea..79234aa 100644
--- a/lib/PublicInbox/Unsubscribe.pm
+++ b/lib/PublicInbox/Unsubscribe.pm
@@ -158,7 +158,7 @@ sub archive_info {
}
# protocol-relative URL: "//example.com/" => "https://example.com/"
- if ($archive_url =~ m!\A//!) {
+ if ($archive_url && $archive_url =~ m!\A//!) {
$archive_url = "$env->{'psgi.url_scheme'}:$archive_url";
}
^ permalink raw reply related [relevance 7%]
* [PATCH] unsubscribe: archive_url may be undefined
@ 2016-06-15 1:40 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2016-06-15 1:40 UTC (permalink / raw)
To: meta
We'll show a nasty warning in the UI instead of triggering
a perl warning about an undefined variable.
---
lib/PublicInbox/Unsubscribe.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Unsubscribe.pm b/lib/PublicInbox/Unsubscribe.pm
index 239feea..79234aa 100644
--- a/lib/PublicInbox/Unsubscribe.pm
+++ b/lib/PublicInbox/Unsubscribe.pm
@@ -158,7 +158,7 @@ sub archive_info {
}
# protocol-relative URL: "//example.com/" => "https://example.com/"
- if ($archive_url =~ m!\A//!) {
+ if ($archive_url && $archive_url =~ m!\A//!) {
$archive_url = "$env->{'psgi.url_scheme'}:$archive_url";
}
^ permalink raw reply related [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-06-15 1:31 [PATCH] inbox: allow undef return value for base_url Eric Wong
2016-06-15 1:40 7% ` [PATCH] unsubscribe: archive_url may be undefined Eric Wong
2016-06-15 21:12 7% Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).