From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 680361FE36; Wed, 15 Jun 2016 01:40:25 +0000 (UTC) Date: Wed, 15 Jun 2016 01:40:25 +0000 From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] unsubscribe: archive_url may be undefined Message-ID: <20160615014025.GA20963@dcvr.yhbt.net> References: <20160615013159.15625-1-e@80x24.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160615013159.15625-1-e@80x24.org> List-Id: We'll show a nasty warning in the UI instead of triggering a perl warning about an undefined variable. --- lib/PublicInbox/Unsubscribe.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/Unsubscribe.pm b/lib/PublicInbox/Unsubscribe.pm index 239feea..79234aa 100644 --- a/lib/PublicInbox/Unsubscribe.pm +++ b/lib/PublicInbox/Unsubscribe.pm @@ -158,7 +158,7 @@ sub archive_info { } # protocol-relative URL: "//example.com/" => "https://example.com/" - if ($archive_url =~ m!\A//!) { + if ($archive_url && $archive_url =~ m!\A//!) { $archive_url = "$env->{'psgi.url_scheme'}:$archive_url"; }