user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* Re: [PATCH] tests: recommend running create-certs.pl with $^X
  2019-10-02 21:36  6% ` [PATCH] tests: recommend running create-certs.pl with $^X Alyssa Ross
@ 2019-10-02 23:19  7%   ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-10-02 23:19 UTC (permalink / raw)
  To: Alyssa Ross; +Cc: meta

Alyssa Ross <hi@alyssa.is> wrote:
> This is better than recommending running the script directly because
> it will ensure the correct version of perl is used.

Applied and pushed, thanks!

^ permalink raw reply	[relevance 7%]

* [PATCH] tests: recommend running create-certs.pl with $^X
  @ 2019-10-02 21:36  6% ` Alyssa Ross
  2019-10-02 23:19  7%   ` Eric Wong
  0 siblings, 1 reply; 2+ results
From: Alyssa Ross @ 2019-10-02 21:36 UTC (permalink / raw)
  To: Eric Wong; +Cc: meta, Alyssa Ross

This is better than recommending running the script directly because
it will ensure the correct version of perl is used.
---
 t/httpd-https.t    | 2 +-
 t/nntpd-tls.t      | 2 +-
 t/nntpd-validate.t | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/t/httpd-https.t b/t/httpd-https.t
index 410ae65..22c62bf 100644
--- a/t/httpd-https.t
+++ b/t/httpd-https.t
@@ -14,7 +14,7 @@ my $cert = 'certs/server-cert.pem';
 my $key = 'certs/server-key.pem';
 unless (-r $key && -r $cert) {
 	plan skip_all =>
-		"certs/ missing for $0, run ./create-certs.perl in certs/";
+		"certs/ missing for $0, run $^X ./create-certs.perl in certs/";
 }
 use_ok 'PublicInbox::TLS';
 use_ok 'IO::Socket::SSL';
diff --git a/t/nntpd-tls.t b/t/nntpd-tls.t
index e961965..1a74924 100644
--- a/t/nntpd-tls.t
+++ b/t/nntpd-tls.t
@@ -20,7 +20,7 @@ my $cert = 'certs/server-cert.pem';
 my $key = 'certs/server-key.pem';
 unless (-r $key && -r $cert) {
 	plan skip_all =>
-		"certs/ missing for $0, run ./create-certs.perl in certs/";
+		"certs/ missing for $0, run $^X ./create-certs.perl in certs/";
 }
 
 use_ok 'PublicInbox::TLS';
diff --git a/t/nntpd-validate.t b/t/nntpd-validate.t
index 532ef72..87829b0 100644
--- a/t/nntpd-validate.t
+++ b/t/nntpd-validate.t
@@ -32,7 +32,7 @@ my $test_tls = $ENV{TEST_SKIP_TLS} ? 0 : eval { require IO::Socket::SSL };
 my $cert = 'certs/server-cert.pem';
 my $key = 'certs/server-key.pem';
 if ($test_tls && !-r $key || !-r $cert) {
-	plan skip_all => "certs/ missing for $0, run ./certs/create-certs.perl";
+	plan skip_all => "certs/ missing for $0, run $^X ./certs/create-certs.perl";
 }
 require './t/common.perl';
 my $keep_tmp = !!$ENV{TEST_KEEP_TMP};
-- 
2.23.0


^ permalink raw reply related	[relevance 6%]

Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-10-01 20:58     [PATCH] #!/usr/bin/perl -> #!/usr/bin/env perl Eric Wong
2019-10-02 21:36  6% ` [PATCH] tests: recommend running create-certs.pl with $^X Alyssa Ross
2019-10-02 23:19  7%   ` Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).