From: Eric Wong <email@example.com>
To: Alyssa Ross <firstname.lastname@example.org>
Subject: Re: [PATCH] #!/usr/bin/perl -> #!/usr/bin/env perl
Date: Tue, 1 Oct 2019 20:58:14 +0000 [thread overview]
Message-ID: <20191001205814.GA19918@dcvr> (raw)
Alyssa Ross <email@example.com> wrote:
> >> certs/create-certs.perl | 2 +-
> > Documentation in corresponding t/*.t files could be better
> > about running that and instead recommend "$^X"
> Makes sense. This was the one that was giving me problems in the first
> >> t/hl_mod.t | 2 +-
> > Oops, there probably shouldn't have a shebang there at all
> > since none of the other *.t files have it. I've also seen
> > "#!perl -w" (no '/' at all) in other projects, but I don't think
> > it's worth the effort unless some external tools/highlighters
> > work better with it. I expect "#!/usr/bin/perl -w" to be most
> > compatible with highlighters and stuff like file(1).
> #!perl has some nice characteristics -- it's understood by the
> interpreter for setting flags, and for -x, but at the same time it's
> clear that a file with #!perl is not supposed to be directly executed.
Agreed. However, I'm not sure if compatibility with
highlighters would be as good as a full path.
> Assuming you don't want to change to #!perl, do you want a patch to
> recommend running certs/create-certs.perl and remove the shebang from
> t/hl_mod.t? And should the executable bits still be set on the other
Just the messages in t/*.t for certs/create-certs.perl is fine.
I don't think the other changes would affect users/testers.
Also, t/hl_mod.t as-is could be a good comparison for syntax
highlighters in the future (and I am leaning towards dropping
Not sure if there's executable bits worth changing, now; I think
it's a good way to inform users that a given file can be
executed (rather than loaded via `require'); but the '.t' files
might be a special case...
next prev parent reply other threads:[~2019-10-01 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 20:43 [PATCH] #!/usr/bin/perl -> #!/usr/bin/env perl Alyssa Ross
2019-09-26 2:49 ` Eric Wong
2019-10-01 17:47 ` Alyssa Ross
2019-10-01 20:58 ` Eric Wong [this message]
2019-10-02 21:36 ` [PATCH] tests: recommend running create-certs.pl with $^X Alyssa Ross
2019-10-02 23:19 ` Eric Wong
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).