Re: [PATCH] #!/usr/bin/perl -> #!/usr/bin/env perl

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

>>  certs/create-certs.perl       | 2 +-
>
> Documentation in corresponding t/*.t files could be better
> about running that and instead recommend "$^X"

Makes sense.  This was the one that was giving me problems in the first
place.

>>  t/hl_mod.t                    | 2 +-
>
> Oops, there probably shouldn't have a shebang there at all
> since none of the other *.t files have it.  I've also seen
> "#!perl -w" (no '/' at all) in other projects, but I don't think
> it's worth the effort unless some external tools/highlighters
> work better with it. I expect "#!/usr/bin/perl -w" to be most
> compatible with highlighters and stuff like file(1).

#!perl has some nice characteristics -- it's understood by the
interpreter for setting flags, and for -x, but at the same time it's
clear that a file with #!perl is not supposed to be directly executed.

Assuming you don't want to change to #!perl, do you want a patch to
recommend running certs/create-certs.perl and remove the shebang from
t/hl_mod.t?  And should the executable bits still be set on the other
files?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]