* Re: [PATCH 0/4] minor test cleanups
2018-07-18 0:30 4% [PATCH 0/4] minor test cleanups Eric W. Biederman
2018-07-18 0:32 7% ` [PATCH 3/4] t/v2reindex.t: Don't reuse $ibx as two different kinds of variable Eric W. Biederman
@ 2018-07-18 10:30 0% ` Eric Wong
1 sibling, 0 replies; 3+ results
From: Eric Wong @ 2018-07-18 10:30 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: meta
"Eric W. Biederman" <ebiederm@xmission.com> wrote:
> While developing the ability to disable the indexes I found a few places
> where the existing tests could be slightly improved.
Thanks! I'm not a very good test writer :x
> Here are my improvements.
>
> Eric W. Biederman (4):
> t/v2reindex.t: Ensure the numbers 1 to 10 are used
> t/search.t t/v2writable.t: Teach search tests to fail more cleanly.
I'm not thrilled with the longer lines >=80 cols, but I won't
make you reroll, either.
> t/v2reindex.t: Don't reuse $ibx as two different kinds of variable
> t/v2reindex.t: Swap the order of minmax tests so errors make sense
All four of these are pushed along with the regen_down fix for
v1. Will await comments on index levels. Thanks again.
^ permalink raw reply [relevance 0%]
* [PATCH 3/4] t/v2reindex.t: Don't reuse $ibx as two different kinds of variable
2018-07-18 0:30 4% [PATCH 0/4] minor test cleanups Eric W. Biederman
@ 2018-07-18 0:32 7% ` Eric W. Biederman
2018-07-18 10:30 0% ` [PATCH 0/4] minor test cleanups Eric Wong
1 sibling, 0 replies; 3+ results
From: Eric W. Biederman @ 2018-07-18 0:32 UTC (permalink / raw)
To: Eric Wong; +Cc: meta, Eric W. Biederman
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
t/v2reindex.t | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/v2reindex.t b/t/v2reindex.t
index f8e2b1b2d46e..5bc307f1cac1 100644
--- a/t/v2reindex.t
+++ b/t/v2reindex.t
@@ -14,13 +14,13 @@ foreach my $mod (qw(DBD::SQLite Search::Xapian)) {
}
use_ok 'PublicInbox::V2Writable';
my $mainrepo = tempdir('pi-v2reindex-XXXXXX', TMPDIR => 1, CLEANUP => 1);
-my $ibx = {
+my $ibx_config = {
mainrepo => $mainrepo,
name => 'test-v2writable',
version => 2,
-primary_address => 'test@example.com',
};
-$ibx = PublicInbox::Inbox->new($ibx);
+my $ibx = PublicInbox::Inbox->new($ibx_config);
my $mime = PublicInbox::MIME->create(
header => [
From => 'a@example.com',
--
2.17.1
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] minor test cleanups
@ 2018-07-18 0:30 4% Eric W. Biederman
2018-07-18 0:32 7% ` [PATCH 3/4] t/v2reindex.t: Don't reuse $ibx as two different kinds of variable Eric W. Biederman
2018-07-18 10:30 0% ` [PATCH 0/4] minor test cleanups Eric Wong
0 siblings, 2 replies; 3+ results
From: Eric W. Biederman @ 2018-07-18 0:30 UTC (permalink / raw)
To: Eric Wong; +Cc: meta
While developing the ability to disable the indexes I found a few places
where the existing tests could be slightly improved.
Here are my improvements.
Eric W. Biederman (4):
t/v2reindex.t: Ensure the numbers 1 to 10 are used
t/search.t t/v2writable.t: Teach search tests to fail more cleanly.
t/v2reindex.t: Don't reuse $ibx as two different kinds of variable
t/v2reindex.t: Swap the order of minmax tests so errors make sense
t/search.t | 45 ++++++++++++++++++++++++++-------------------
t/v2reindex.t | 11 ++++++-----
t/v2writable.t | 2 +-
3 files changed, 33 insertions(+), 25 deletions(-)
Eric
^ permalink raw reply [relevance 4%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2018-07-18 0:30 4% [PATCH 0/4] minor test cleanups Eric W. Biederman
2018-07-18 0:32 7% ` [PATCH 3/4] t/v2reindex.t: Don't reuse $ibx as two different kinds of variable Eric W. Biederman
2018-07-18 10:30 0% ` [PATCH 0/4] minor test cleanups Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).