From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 28D211F597;
	Wed, 18 Jul 2018 10:30:30 +0000 (UTC)
Date: Wed, 18 Jul 2018 10:30:30 +0000
From: Eric Wong <e@80x24.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 0/4] minor test cleanups
Message-ID: <20180718103029.d2lk62rfxc5dzsgx@whir>
References: <87sh4hidvg.fsf@xmission.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87sh4hidvg.fsf@xmission.com>
List-Id: <meta.public-inbox.org>

"Eric W. Biederman" <ebiederm@xmission.com> wrote:
> While developing the ability to disable the indexes I found a few places
> where the existing tests could be slightly improved.

Thanks!  I'm not a very good test writer :x

> Here are my improvements.
> 
> Eric W. Biederman (4):
>       t/v2reindex.t: Ensure the numbers 1 to 10 are used
>       t/search.t t/v2writable.t: Teach search tests to fail more cleanly.

I'm not thrilled with the longer lines >=80 cols, but I won't
make you reroll, either.

>       t/v2reindex.t:  Don't reuse $ibx as two different kinds of variable
>       t/v2reindex.t: Swap the order of minmax tests so errors make sense

All four of these are pushed along with the regen_down fix for
v1.  Will await comments on index levels.  Thanks again.