* [PATCH 2/3] t/v2mda: make it easy to test v1 repos here, too
2018-07-29 9:34 3% [PATCH 0/3] mda: v2: ensure message bodies are indexed Eric Wong
@ 2018-07-29 9:34 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2018-07-29 9:34 UTC (permalink / raw)
To: meta
It will help track down a bug which only seems to happen in v2 repos.
---
t/v2mda.t | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/t/v2mda.t b/t/v2mda.t
index f386289..7df3a43 100644
--- a/t/v2mda.t
+++ b/t/v2mda.t
@@ -8,6 +8,7 @@ use File::Temp qw/tempdir/;
use Fcntl qw(SEEK_SET);
use Cwd;
+my $V = 2;
foreach my $mod (qw(DBD::SQLite Search::Xapian)) {
eval "require $mod";
plan skip_all => "$mod missing for v2mda.t" if $@;
@@ -38,7 +39,8 @@ local $ENV{PI_DIR} = "$tmpdir/foo";
local $ENV{PATH} = "$main_bin:blib/script:$ENV{PATH}";
local $ENV{PI_EMERGENCY} = "$tmpdir/fail";
ok(mkdir "$tmpdir/fail");
-my @cmd = (qw(public-inbox-init -V2), $ibx->{name},
+
+my @cmd = (qw(public-inbox-init), "-V$V", $ibx->{name},
$ibx->{mainrepo}, 'http://localhost/test',
$ibx->{address}->[0]);
ok(PublicInbox::Import::run_die(\@cmd), 'initialized v2 inbox');
@@ -54,6 +56,11 @@ ok(PublicInbox::Import::run_die(['public-inbox-mda'], undef, $rdr),
'mda delivered a message');
$ibx = PublicInbox::Inbox->new($ibx);
+
+if ($V == 1) {
+ my $cmd = [ 'public-inbox-index', "$tmpdir/inbox" ];
+ ok(PublicInbox::Import::run_die($cmd, undef, $rdr), 'v1 indexed');
+}
my $msgs = $ibx->search->query('');
my $saved = $ibx->smsg_mime($msgs->[0]);
is($saved->{mime}->as_string, $mime->as_string, 'injected message');
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] mda: v2: ensure message bodies are indexed
@ 2018-07-29 9:34 3% Eric Wong
2018-07-29 9:34 7% ` [PATCH 2/3] t/v2mda: make it easy to test v1 repos here, too Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2018-07-29 9:34 UTC (permalink / raw)
To: meta
I found a bug for v2 users getting mail through -mda, causing
message bodies to not show up in the search results. It was a
stupid one-line bug made in an effort to save memory :x
Anyways, to properly index message bodies on affected mda-using
v2 inboxes, a reindex is required:
public-inbox-index --reindex
This can take a long while and requires roughly double the
current Xapian storage. However, it's designed to run online
so users will gradually find search more useful as indexing
completes (it runs in reverse-chronological order)
Fwiw, I always run indexing with "eatmydata" to disable fsync
and speed up the process, since Xapian data isn't critical.
I suppose another idea is to allow passing a limit to reindex,
as this bug didn't affect initial imports... (But I'm tired
and I fixed this bug while getting sidetracked from another
bugfix on another project)
Eric Wong (3):
mda: use InboxWritable
t/v2mda: make it easy to test v1 repos here, too
mda: v2: ensure message bodies are indexed
MANIFEST | 1 +
lib/PublicInbox/InboxWritable.pm | 1 +
script/public-inbox-mda | 38 +++++++-------------------
t/data/0001.patch | 46 ++++++++++++++++++++++++++++++++
t/v2mda.t | 19 ++++++++++++-
t/watch_maildir_v2.t | 15 +++++++++++
6 files changed, 91 insertions(+), 29 deletions(-)
create mode 100644 t/data/0001.patch
--
EW
^ permalink raw reply [relevance 3%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2018-07-29 9:34 3% [PATCH 0/3] mda: v2: ensure message bodies are indexed Eric Wong
2018-07-29 9:34 7% ` [PATCH 2/3] t/v2mda: make it easy to test v1 repos here, too Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).