From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 5883B1F597 for ; Sun, 29 Jul 2018 09:34:41 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 0/3] mda: v2: ensure message bodies are indexed Date: Sun, 29 Jul 2018 09:34:38 +0000 Message-Id: <20180729093441.5250-1-e@80x24.org> List-Id: I found a bug for v2 users getting mail through -mda, causing message bodies to not show up in the search results. It was a stupid one-line bug made in an effort to save memory :x Anyways, to properly index message bodies on affected mda-using v2 inboxes, a reindex is required: public-inbox-index --reindex This can take a long while and requires roughly double the current Xapian storage. However, it's designed to run online so users will gradually find search more useful as indexing completes (it runs in reverse-chronological order) Fwiw, I always run indexing with "eatmydata" to disable fsync and speed up the process, since Xapian data isn't critical. I suppose another idea is to allow passing a limit to reindex, as this bug didn't affect initial imports... (But I'm tired and I fixed this bug while getting sidetracked from another bugfix on another project) Eric Wong (3): mda: use InboxWritable t/v2mda: make it easy to test v1 repos here, too mda: v2: ensure message bodies are indexed MANIFEST | 1 + lib/PublicInbox/InboxWritable.pm | 1 + script/public-inbox-mda | 38 +++++++------------------- t/data/0001.patch | 46 ++++++++++++++++++++++++++++++++ t/v2mda.t | 19 ++++++++++++- t/watch_maildir_v2.t | 15 +++++++++++ 6 files changed, 91 insertions(+), 29 deletions(-) create mode 100644 t/data/0001.patch -- EW