* [PATCH 1/5] searchview: get rid of unused adump callback arg
2024-04-24 6:44 5% [PATCH 0/5] www: start using xap_helper process Eric Wong
@ 2024-04-24 6:44 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2024-04-24 6:44 UTC (permalink / raw)
To: meta
It hasn't been used since 2016 when we started working on
improved streamability of gigantic responses.
Fixes: 95d4bf7aded4 (atom: switch to getline/close for response bodies, 2016-12-03)
---
lib/PublicInbox/SearchView.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index 2d3e942c..4016ddeb 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -75,7 +75,7 @@ retry:
$code = 404;
$html = "<pre>\n[No results found]</pre><hr>";
} else {
- return adump($_[0], $mset, $q, $ctx) if $x eq 'A';
+ return adump($mset, $q, $ctx) if $x eq 'A';
$ctx->{-html_tip} = search_nav_top($mset, $q, $ctx);
return mset_thread($ctx, $mset, $q) if $x eq 't';
@@ -357,7 +357,7 @@ sub ctx_prepare {
}
sub adump {
- my ($cb, $mset, $q, $ctx) = @_;
+ my ($mset, $q, $ctx) = @_;
$ctx->{ids} = $ctx->{ibx}->isrch->mset_to_artnums($mset);
$ctx->{search_query} = $q; # used by WwwAtomStream::atom_header
PublicInbox::WwwAtomStream->response($ctx, \&adump_i);
^ permalink raw reply related [relevance 7%]
* [PATCH 0/5] www: start using xap_helper process
@ 2024-04-24 6:44 5% Eric Wong
2024-04-24 6:44 7% ` [PATCH 1/5] searchview: get rid of unused adump callback arg Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2024-04-24 6:44 UTC (permalink / raw)
To: meta
Putting Xapian work into subprocesses will allow us to implement
proper timeouts and ultra-expensive queries without harming
unrelated queries.
It's on by default right now, but I think it's better to keep it
off by default to avoid tripping up existing process monitoring
tools.
Eric Wong (5):
searchview: get rid of unused adump callback arg
xap_helper.h: remove _SC_NPROCESSORS_ONLN default
xap_helper: drop terms+data from `mset' command
mbox: hoist out refill_result_ids
www: wire up search to use async xap_helper
MANIFEST | 2 +
lib/PublicInbox/Isearch.pm | 50 +++++++-----
lib/PublicInbox/Mbox.pm | 127 ++++++++++++++++-------------
lib/PublicInbox/MboxGz.pm | 4 +-
lib/PublicInbox/Search.pm | 53 +++++++++++-
lib/PublicInbox/SearchView.pm | 58 +++++++------
lib/PublicInbox/XapClient.pm | 1 +
lib/PublicInbox/XapHelper.pm | 16 +---
lib/PublicInbox/XhcMset.pm | 51 ++++++++++++
lib/PublicInbox/XhcMsetIterator.pm | 20 +++++
lib/PublicInbox/xap_helper.h | 17 ++--
lib/PublicInbox/xh_mset.h | 57 ++-----------
t/cindex.t | 23 +++---
t/xap_helper.t | 29 +++----
14 files changed, 302 insertions(+), 206 deletions(-)
create mode 100644 lib/PublicInbox/XhcMset.pm
create mode 100644 lib/PublicInbox/XhcMsetIterator.pm
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2024-04-24 6:44 5% [PATCH 0/5] www: start using xap_helper process Eric Wong
2024-04-24 6:44 7% ` [PATCH 1/5] searchview: get rid of unused adump callback arg Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).