From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/5] searchview: get rid of unused adump callback arg
Date: Wed, 24 Apr 2024 06:44:43 +0000 [thread overview]
Message-ID: <20240424064447.523799-2-e@80x24.org> (raw)
In-Reply-To: <20240424064447.523799-1-e@80x24.org>
It hasn't been used since 2016 when we started working on
improved streamability of gigantic responses.
Fixes: 95d4bf7aded4 (atom: switch to getline/close for response bodies, 2016-12-03)
---
lib/PublicInbox/SearchView.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index 2d3e942c..4016ddeb 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -75,7 +75,7 @@ retry:
$code = 404;
$html = "<pre>\n[No results found]</pre><hr>";
} else {
- return adump($_[0], $mset, $q, $ctx) if $x eq 'A';
+ return adump($mset, $q, $ctx) if $x eq 'A';
$ctx->{-html_tip} = search_nav_top($mset, $q, $ctx);
return mset_thread($ctx, $mset, $q) if $x eq 't';
@@ -357,7 +357,7 @@ sub ctx_prepare {
}
sub adump {
- my ($cb, $mset, $q, $ctx) = @_;
+ my ($mset, $q, $ctx) = @_;
$ctx->{ids} = $ctx->{ibx}->isrch->mset_to_artnums($mset);
$ctx->{search_query} = $q; # used by WwwAtomStream::atom_header
PublicInbox::WwwAtomStream->response($ctx, \&adump_i);
next prev parent reply other threads:[~2024-04-24 6:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 6:44 [PATCH 0/5] www: start using xap_helper process Eric Wong
2024-04-24 6:44 ` Eric Wong [this message]
2024-04-24 6:44 ` [PATCH 2/5] xap_helper.h: remove _SC_NPROCESSORS_ONLN default Eric Wong
2024-04-24 6:44 ` [PATCH 3/5] xap_helper: drop terms+data from `mset' command Eric Wong
2024-04-24 6:44 ` [PATCH 4/5] mbox: hoist out refill_result_ids Eric Wong
2024-04-24 6:44 ` [PATCH 5/5] www: wire up search to use async xap_helper Eric Wong
2024-04-24 9:39 ` [PATCH 6/5] xap_helper: PERL_INLINE_DIRECTORY fallback for JAOT build Eric Wong
2024-04-25 8:11 ` BSD make problem [was: [PATCH 5/5] www: wire up search ...] Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424064447.523799-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).