From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/5] xap_helper.h: remove _SC_NPROCESSORS_ONLN default
Date: Wed, 24 Apr 2024 06:44:44 +0000 [thread overview]
Message-ID: <20240424064447.523799-3-e@80x24.org> (raw)
In-Reply-To: <20240424064447.523799-1-e@80x24.org>
It's never straightforward to pick an ideal number of processes
for anything and Xapian helper processes are no exception since
there may be a massive disparities in CPU count and I/O
performance. So default to a single worker for now in the C++
version since that's the default is for the Perl/(XS|SWIG)
version, and also the same as for our normal public-facing
daemons.
This keeps the behavior between the Perl+(XS|SWIG) and C++
version as similar as possible.
---
lib/PublicInbox/xap_helper.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/lib/PublicInbox/xap_helper.h b/lib/PublicInbox/xap_helper.h
index 3456910b..0e6805b3 100644
--- a/lib/PublicInbox/xap_helper.h
+++ b/lib/PublicInbox/xap_helper.h
@@ -945,12 +945,6 @@ int main(int argc, char *argv[])
}
nworker = 1;
-#ifdef _SC_NPROCESSORS_ONLN
- long j = sysconf(_SC_NPROCESSORS_ONLN);
- if (j > 0)
- nworker = j > WORKER_MAX ? WORKER_MAX : j;
-#endif // _SC_NPROCESSORS_ONLN
-
// make warn/warnx/err multi-process friendly:
if (my_setlinebuf(stderr))
err(EXIT_FAILURE, "setlinebuf(stderr)");
next prev parent reply other threads:[~2024-04-24 6:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 6:44 [PATCH 0/5] www: start using xap_helper process Eric Wong
2024-04-24 6:44 ` [PATCH 1/5] searchview: get rid of unused adump callback arg Eric Wong
2024-04-24 6:44 ` Eric Wong [this message]
2024-04-24 6:44 ` [PATCH 3/5] xap_helper: drop terms+data from `mset' command Eric Wong
2024-04-24 6:44 ` [PATCH 4/5] mbox: hoist out refill_result_ids Eric Wong
2024-04-24 6:44 ` [PATCH 5/5] www: wire up search to use async xap_helper Eric Wong
2024-04-24 9:39 ` [PATCH 6/5] xap_helper: PERL_INLINE_DIRECTORY fallback for JAOT build Eric Wong
2024-04-25 8:11 ` BSD make problem [was: [PATCH 5/5] www: wire up search ...] Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424064447.523799-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).