* [PATCH 2/3] searchview: fix unclosed tags in threaded search results
2015-12-26 1:30 6% [PATCH 0/3] minor view tweaks Eric Wong
@ 2015-12-26 1:30 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2015-12-26 1:30 UTC (permalink / raw)
To: meta
Oops, we've had this forever and we also lacked a space
between the this was noticed while adding an extra
line between the "Search results ordered by" header
and actual messages.
---
lib/PublicInbox/SearchView.pm | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index 994bf0d..8751fca 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -43,13 +43,13 @@ sub sres_top_html {
my $x = $q->{x};
return sub { adump($_[0], $mset, $q, $ctx) } if ($x eq 'A');
- $res .= search_nav_top($mset, $q);
+ $res .= search_nav_top($mset, $q) . "\n\n";
if ($x eq 't') {
return sub { tdump($_[0], $res, $mset, $q, $ctx) };
}
- $res .= "\n\n";
dump_mset(\$res, $mset);
- $res .= search_nav_bot($mset, $q) . "\n\n" . foot($ctx);
+ $res .= '</pre>' . search_nav_bot($mset, $q) .
+ "\n\n" . foot($ctx);
}
$res .= "</pre></body></html>";
@@ -111,8 +111,7 @@ sub search_nav_top {
$rv .= qq{<b>threaded</b>};
}
my $A = $q->qs_html(x => 'A', r => undef);
- $rv .= qq{|<a\nhref="?$A">Atom</a>};
- $rv .= ']';
+ $rv .= qq{|<a\nhref="?$A">Atom</a>]};
}
sub search_nav_bot {
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] minor view tweaks
@ 2015-12-26 1:30 6% Eric Wong
2015-12-26 1:30 7% ` [PATCH 2/3] searchview: fix unclosed tags in threaded search results Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2015-12-26 1:30 UTC (permalink / raw)
To: meta
3 changes to be pushed to git://80x24.org/public-inbox.org master:
view: reduce main landing page weight
searchview: fix unclosed tags in threaded search results
use "Atom feed" consistently in headers/footers
lib/PublicInbox/Feed.pm | 2 +-
lib/PublicInbox/SearchView.pm | 15 ++++++---------
lib/PublicInbox/View.pm | 23 +++++++++--------------
3 files changed, 16 insertions(+), 24 deletions(-)
Additionally (sent separately):
searchview: fixup stupid syntax error
searchview: fix up Atom feed in search results
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-12-26 1:30 6% [PATCH 0/3] minor view tweaks Eric Wong
2015-12-26 1:30 7% ` [PATCH 2/3] searchview: fix unclosed tags in threaded search results Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).