From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.8 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: meta@public-inbox.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 1AA95633806 for ; Sat, 26 Dec 2015 01:30:27 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/3] searchview: fix unclosed tags in threaded search results Date: Sat, 26 Dec 2015 01:30:20 +0000 Message-Id: <20151226013021.5006-3-e@80x24.org> In-Reply-To: <20151226013021.5006-1-e@80x24.org> References: <20151226013021.5006-1-e@80x24.org> List-Id: Oops, we've had this forever and we also lacked a space between the this was noticed while adding an extra line between the "Search results ordered by" header and actual messages. --- lib/PublicInbox/SearchView.pm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm index 994bf0d..8751fca 100644 --- a/lib/PublicInbox/SearchView.pm +++ b/lib/PublicInbox/SearchView.pm @@ -43,13 +43,13 @@ sub sres_top_html { my $x = $q->{x}; return sub { adump($_[0], $mset, $q, $ctx) } if ($x eq 'A'); - $res .= search_nav_top($mset, $q); + $res .= search_nav_top($mset, $q) . "\n\n"; if ($x eq 't') { return sub { tdump($_[0], $res, $mset, $q, $ctx) }; } - $res .= "\n\n"; dump_mset(\$res, $mset); - $res .= search_nav_bot($mset, $q) . "\n\n" . foot($ctx); + $res .= '' . search_nav_bot($mset, $q) . + "\n\n" . foot($ctx); } $res .= ""; @@ -111,8 +111,7 @@ sub search_nav_top { $rv .= qq{threaded}; } my $A = $q->qs_html(x => 'A', r => undef); - $rv .= qq{|Atom}; - $rv .= ']'; + $rv .= qq{|Atom]}; } sub search_nav_bot { -- EW