* [PATCH 2/3] searchidx: v1: skip mid_clean on mid_mime results
2020-04-01 6:16 5% [PATCH 0/3] Message-ID-related cleanups Eric Wong
@ 2020-04-01 6:16 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-04-01 6:16 UTC (permalink / raw)
To: meta
We do not need run mid_clean() since mid_mime() uses mids()
to extract the msgid from inside the angle brackets.
---
lib/PublicInbox/SearchIdx.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 7d089e7a..fe00df53 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -497,13 +497,13 @@ sub index_git_blob_id {
sub unindex_blob {
my ($self, $mime) = @_;
- my $mid = eval { mid_clean(mid_mime($mime)) };
+ my $mid = eval { mid_mime($mime) };
$self->remove_message($mid) if defined $mid;
}
sub index_mm {
my ($self, $mime) = @_;
- my $mid = mid_clean(mid_mime($mime));
+ my $mid = mid_mime($mime);
my $mm = $self->{mm};
my $num;
@@ -534,7 +534,7 @@ sub index_mm {
sub unindex_mm {
my ($self, $mime) = @_;
- $self->{mm}->mid_delete(mid_clean(mid_mime($mime)));
+ $self->{mm}->mid_delete(mid_mime($mime));
}
sub index_both {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] Message-ID-related cleanups
@ 2020-04-01 6:16 5% Eric Wong
2020-04-01 6:16 7% ` [PATCH 2/3] searchidx: v1: skip mid_clean on mid_mime results Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-04-01 6:16 UTC (permalink / raw)
To: meta
While I'm still not sure what to do about spaces in Message-IDs(*),
I noticed some improvements that could be made to make our Message-ID
handling code more consistent.
(*) https://public-inbox.org/meta/20200331083250.GA27164@dcvr/
Eric Wong (3):
smsg: inline _extract_mid functionality
searchidx: v1: skip mid_clean on mid_mime results
mid: add $MID_EXTRACT regexp for export
lib/PublicInbox/Linkify.pm | 3 ++-
lib/PublicInbox/MID.pm | 12 +++++++-----
lib/PublicInbox/NNTP.pm | 16 ++++++++--------
lib/PublicInbox/SearchIdx.pm | 6 +++---
lib/PublicInbox/SearchThread.pm | 3 ++-
lib/PublicInbox/Smsg.pm | 6 ++----
lib/PublicInbox/View.pm | 5 +++--
scripts/ssoma-replay | 2 +-
8 files changed, 28 insertions(+), 25 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-04-01 6:16 5% [PATCH 0/3] Message-ID-related cleanups Eric Wong
2020-04-01 6:16 7% ` [PATCH 2/3] searchidx: v1: skip mid_clean on mid_mime results Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).