From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 2/3] searchidx: v1: skip mid_clean on mid_mime results
Date: Wed, 1 Apr 2020 06:16:19 +0000 [thread overview]
Message-ID: <20200401061620.29276-3-e@yhbt.net> (raw)
In-Reply-To: <20200401061620.29276-1-e@yhbt.net>
We do not need run mid_clean() since mid_mime() uses mids()
to extract the msgid from inside the angle brackets.
---
lib/PublicInbox/SearchIdx.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 7d089e7a..fe00df53 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -497,13 +497,13 @@ sub index_git_blob_id {
sub unindex_blob {
my ($self, $mime) = @_;
- my $mid = eval { mid_clean(mid_mime($mime)) };
+ my $mid = eval { mid_mime($mime) };
$self->remove_message($mid) if defined $mid;
}
sub index_mm {
my ($self, $mime) = @_;
- my $mid = mid_clean(mid_mime($mime));
+ my $mid = mid_mime($mime);
my $mm = $self->{mm};
my $num;
@@ -534,7 +534,7 @@ sub index_mm {
sub unindex_mm {
my ($self, $mime) = @_;
- $self->{mm}->mid_delete(mid_clean(mid_mime($mime)));
+ $self->{mm}->mid_delete(mid_mime($mime));
}
sub index_both {
next prev parent reply other threads:[~2020-04-01 6:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 6:16 [PATCH 0/3] Message-ID-related cleanups Eric Wong
2020-04-01 6:16 ` [PATCH 1/3] smsg: inline _extract_mid functionality Eric Wong
2020-04-01 6:16 ` Eric Wong [this message]
2020-04-01 6:16 ` [PATCH 3/3] mid: add $MID_EXTRACT regexp for export Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401061620.29276-3-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).