* [PATCH 5/9] overidx: parse_references: less error-prone args
2020-03-20 8:18 5% ` [PATCH 0/9] preserve time and date of initial commit Eric Wong
@ 2020-03-20 8:18 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-03-20 8:18 UTC (permalink / raw)
To: meta
Favor `$smsg->{mid}' instead of `$mid0' to reduce parameters
down-the-line, but favor passing the Email::MIME::Header object
around instead of relying on the bloat-prone `$smsg->{mime}'
and calling ->header_obj on it.
---
lib/PublicInbox/OverIdx.pm | 8 +++-----
lib/PublicInbox/SearchIdx.pm | 2 +-
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm
index 9640f9d1..f49dfa00 100644
--- a/lib/PublicInbox/OverIdx.pm
+++ b/lib/PublicInbox/OverIdx.pm
@@ -216,15 +216,13 @@ sub link_refs {
}
sub parse_references ($$$) {
- my ($smsg, $mid0, $mids) = @_;
- my $mime = $smsg->{mime};
- my $hdr = $mime->header_obj;
+ my ($smsg, $hdr, $mids) = @_;
my $refs = references($hdr);
push(@$refs, @$mids) if scalar(@$mids) > 1;
return $refs if scalar(@$refs) == 0;
# prevent circular references here:
- my %seen = ( $mid0 => 1 );
+ my %seen = ( $smsg->{mid} => 1 );
my @keep;
foreach my $ref (@$refs) {
if (length($ref) > PublicInbox::MID::MAX_MID_SIZE) {
@@ -258,7 +256,7 @@ sub add_overview {
}, 'PublicInbox::Smsg';
my $hdr = $mime->header_obj;
my $mids = mids_for_index($hdr);
- my $refs = parse_references($smsg, $mid0, $mids);
+ my $refs = parse_references($smsg, $hdr, $mids);
my $subj = $smsg->subject;
my $xpath;
if ($subj ne '') {
diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index c0578809..32be9c3f 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -339,9 +339,9 @@ sub add_xapian ($$$$$$) {
}
}
$smsg->{to} = $smsg->{cc} = '';
- PublicInbox::OverIdx::parse_references($smsg, $mid0, $mids);
$smsg->{blob} = $oid;
$smsg->{mid} = $mid0;
+ PublicInbox::OverIdx::parse_references($smsg, $hdr, $mids);
my $data = $smsg->to_doc_data;
$doc->set_data($data);
if (my $altid = $self->{-altid}) {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/9] preserve time and date of initial commit
@ 2020-03-20 8:18 5% ` Eric Wong
2020-03-20 8:18 7% ` [PATCH 5/9] overidx: parse_references: less error-prone args Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-03-20 8:18 UTC (permalink / raw)
To: meta
For messages lacking Date and/or Received headers, search
queries for "d:YYYYMMDD..YYYYMMDD" ranges can be unreliable in
mirrors, as can the $INBOX_URL/?t=$TIMESTAMP query which
only hits SQLite.
Yes, this ended up being a lot of work to deal with corner case
messages (probably most of which are spam), but there's also a
lot of internal cleanups which made the end result easier to
follow, I think...
The main fix is actually in 1/9, but it's gross.
Patch 2/9 fixes a small window where a race can happen and
cause searches to be off by a minute.
Patches 3-8 cleanup the mess left in 1 and 2,
Finally, patch 9 fixes the corner-case-of-corner-cases for
dealing with multi-MID messages which require a one-off queue to
store the git commit/author times instead of overloading msgmap.
Eric Wong (9):
index: use git commit times on missing Date/Received
v2writable: preserve timestamps from import if generated
rename PublicInbox::SearchMsg => PublicInbox::Smsg
smsg: to_doc_data: use existing fields
overidx: parse_references: less error-prone args
*idx: pass $smsg in more places instead of many args
v2: pass smsg in more places
*idx: pass smsg in even more places
v2: SDBM-based multi Message-ID queue
Documentation/mknews.perl | 4 +-
Documentation/technical/data_structures.txt | 4 +-
MANIFEST | 4 +-
lib/PublicInbox/ExtMsg.pm | 3 +-
lib/PublicInbox/Feed.pm | 4 +-
lib/PublicInbox/Import.pm | 19 +++--
lib/PublicInbox/Inbox.pm | 2 +-
lib/PublicInbox/Mbox.pm | 4 +-
lib/PublicInbox/MsgTime.pm | 12 +--
lib/PublicInbox/MultiMidQueue.pm | 57 +++++++++++++
lib/PublicInbox/NNTP.pm | 14 ++--
lib/PublicInbox/Over.pm | 8 +-
lib/PublicInbox/OverIdx.pm | 30 +++----
lib/PublicInbox/Search.pm | 8 +-
lib/PublicInbox/SearchIdx.pm | 68 ++++++++++-----
lib/PublicInbox/SearchIdxShard.pm | 26 ++++--
lib/PublicInbox/SearchView.pm | 8 +-
lib/PublicInbox/{SearchMsg.pm => Smsg.pm} | 19 +++--
lib/PublicInbox/SolverGit.pm | 2 +-
lib/PublicInbox/V2Writable.pm | 84 ++++++++++++-------
lib/PublicInbox/View.pm | 2 +-
t/import.t | 14 ++--
t/index-git-times.t | 93 +++++++++++++++++++++
t/multi-mid.t | 27 +++++-
t/search-thr-index.t | 17 +++-
t/thread-cycle.t | 2 +-
26 files changed, 386 insertions(+), 149 deletions(-)
create mode 100644 lib/PublicInbox/MultiMidQueue.pm
rename lib/PublicInbox/{SearchMsg.pm => Smsg.pm} (92%)
create mode 100644 t/index-git-times.t
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-03-05 5:13 [PATCH] index: use git commit times on missing Date/Received Eric Wong
2020-03-20 8:18 5% ` [PATCH 0/9] preserve time and date of initial commit Eric Wong
2020-03-20 8:18 7% ` [PATCH 5/9] overidx: parse_references: less error-prone args Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).