From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 0/9] preserve time and date of initial commit
Date: Fri, 20 Mar 2020 08:18:12 +0000 [thread overview]
Message-ID: <20200320081821.21715-1-e@yhbt.net> (raw)
In-Reply-To: <20200305051310.GA26952@dcvr>
For messages lacking Date and/or Received headers, search
queries for "d:YYYYMMDD..YYYYMMDD" ranges can be unreliable in
mirrors, as can the $INBOX_URL/?t=$TIMESTAMP query which
only hits SQLite.
Yes, this ended up being a lot of work to deal with corner case
messages (probably most of which are spam), but there's also a
lot of internal cleanups which made the end result easier to
follow, I think...
The main fix is actually in 1/9, but it's gross.
Patch 2/9 fixes a small window where a race can happen and
cause searches to be off by a minute.
Patches 3-8 cleanup the mess left in 1 and 2,
Finally, patch 9 fixes the corner-case-of-corner-cases for
dealing with multi-MID messages which require a one-off queue to
store the git commit/author times instead of overloading msgmap.
Eric Wong (9):
index: use git commit times on missing Date/Received
v2writable: preserve timestamps from import if generated
rename PublicInbox::SearchMsg => PublicInbox::Smsg
smsg: to_doc_data: use existing fields
overidx: parse_references: less error-prone args
*idx: pass $smsg in more places instead of many args
v2: pass smsg in more places
*idx: pass smsg in even more places
v2: SDBM-based multi Message-ID queue
Documentation/mknews.perl | 4 +-
Documentation/technical/data_structures.txt | 4 +-
MANIFEST | 4 +-
lib/PublicInbox/ExtMsg.pm | 3 +-
lib/PublicInbox/Feed.pm | 4 +-
lib/PublicInbox/Import.pm | 19 +++--
lib/PublicInbox/Inbox.pm | 2 +-
lib/PublicInbox/Mbox.pm | 4 +-
lib/PublicInbox/MsgTime.pm | 12 +--
lib/PublicInbox/MultiMidQueue.pm | 57 +++++++++++++
lib/PublicInbox/NNTP.pm | 14 ++--
lib/PublicInbox/Over.pm | 8 +-
lib/PublicInbox/OverIdx.pm | 30 +++----
lib/PublicInbox/Search.pm | 8 +-
lib/PublicInbox/SearchIdx.pm | 68 ++++++++++-----
lib/PublicInbox/SearchIdxShard.pm | 26 ++++--
lib/PublicInbox/SearchView.pm | 8 +-
lib/PublicInbox/{SearchMsg.pm => Smsg.pm} | 19 +++--
lib/PublicInbox/SolverGit.pm | 2 +-
lib/PublicInbox/V2Writable.pm | 84 ++++++++++++-------
lib/PublicInbox/View.pm | 2 +-
t/import.t | 14 ++--
t/index-git-times.t | 93 +++++++++++++++++++++
t/multi-mid.t | 27 +++++-
t/search-thr-index.t | 17 +++-
t/thread-cycle.t | 2 +-
26 files changed, 386 insertions(+), 149 deletions(-)
create mode 100644 lib/PublicInbox/MultiMidQueue.pm
rename lib/PublicInbox/{SearchMsg.pm => Smsg.pm} (92%)
create mode 100644 t/index-git-times.t
next prev parent reply other threads:[~2020-03-20 8:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 3:23 [PATCH] index: use git commit times on missing Date/Received Eric Wong
2020-03-05 5:13 ` Eric Wong
2020-03-20 8:18 ` Eric Wong [this message]
2020-03-20 8:18 ` [PATCH 1/9] " Eric Wong
2020-03-20 8:18 ` [PATCH 2/9] v2writable: preserve timestamps from import Eric Wong
2020-03-20 8:18 ` [PATCH 3/9] rename PublicInbox::SearchMsg => PublicInbox::Smsg Eric Wong
2020-03-20 8:18 ` [PATCH 4/9] smsg: to_doc_data: use existing fields Eric Wong
2020-03-20 8:18 ` [PATCH 5/9] overidx: parse_references: less error-prone args Eric Wong
2020-03-20 8:18 ` [PATCH 6/9] *idx: pass $smsg in more places instead of many args Eric Wong
2020-03-20 8:18 ` [PATCH 7/9] v2: pass smsg in more places Eric Wong
2020-03-20 8:18 ` [PATCH 8/9] *idx: pass smsg in even " Eric Wong
2020-03-20 8:18 ` [PATCH 9/9] v2: SDBM-based multi Message-ID queue Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320081821.21715-1-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).