* [PATCH 0/5] lei: more fixes and usability enhancement
@ 2021-01-25 1:18 7% Eric Wong
2021-01-25 1:18 7% ` [PATCH 2/5] lei q: drop "oid" output format Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-01-25 1:18 UTC (permalink / raw)
To: meta
cccuuurrrlll wwwiiilll nnnooo lllooonnngggeeerrr
ooouuutttpppuuutt llliiikkkeee ttthhhiiisss
Eric Wong (5):
lei: reinstate JSON smsg output deduplication
lei q: drop "oid" output format
lei q: demangle and quiet curl output
lei q: reject remotes early if curl(1) is missing
lei q: continue remote search if torsocks(1) is missing
lib/PublicInbox/LEI.pm | 3 +-
lib/PublicInbox/LeiOverview.pm | 11 +++---
lib/PublicInbox/LeiXSearch.pm | 70 ++++++++++++++++++++++++++--------
t/lei.t | 21 ++++++++--
4 files changed, 79 insertions(+), 26 deletions(-)
^ permalink raw reply [relevance 7%]
* [PATCH 2/5] lei q: drop "oid" output format
2021-01-25 1:18 7% [PATCH 0/5] lei: more fixes and usability enhancement Eric Wong
@ 2021-01-25 1:18 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-01-25 1:18 UTC (permalink / raw)
To: meta
The default deduplication command-line arguments would be
non-sensical for such an option and probably confusing. It
doesn't seem worth the code to support OID-only output when it's
easy enough to use one of the JSON formats to extract the same
info.
We also don't have OIDs if using remotes, and the
to-be-implemented memoization will be optional.
---
lib/PublicInbox/LEI.pm | 3 ++-
lib/PublicInbox/LeiOverview.pm | 4 ----
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm
index 378113e8..09eac58c 100644
--- a/lib/PublicInbox/LEI.pm
+++ b/lib/PublicInbox/LEI.pm
@@ -200,7 +200,8 @@ my %OPTDESC = (
'message/object output format' ],
'mark format|f=s' => $stdin_formats,
'forget format|f=s' => $stdin_formats,
-'q format|f=s' => [ 'OUT|maildir|mboxrd|mboxcl2|mboxcl|html|oid|json',
+'q format|f=s' => [
+ 'OUT|maildir|mboxrd|mboxcl2|mboxcl|html|json|jsonl|concatjson',
'specify output format, default depends on --output'],
'ls-query format|f=s' => $ls_format,
'ls-external format|f=s' => $ls_format,
diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm
index 880c7acc..ea35871c 100644
--- a/lib/PublicInbox/LeiOverview.pm
+++ b/lib/PublicInbox/LeiOverview.pm
@@ -286,10 +286,6 @@ sub ovv_each_smsg_cb { # runs in wq worker usually
$buf = '';
}
}
- } elsif ($self->{fmt} eq 'oid') {
- sub {
- my ($smsg, $mitem) = @_;
- }
} # else { ...
}
^ permalink raw reply related [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-01-25 1:18 7% [PATCH 0/5] lei: more fixes and usability enhancement Eric Wong
2021-01-25 1:18 7% ` [PATCH 2/5] lei q: drop "oid" output format Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).